From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60018)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1WHyOi-0002ow-Fp
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 11:28:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1WHyOh-0007HE-FB
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 11:28:52 -0500
Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::6]:46250)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1WHyOh-0007Fk-5L
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 11:28:51 -0500
Date: Mon, 24 Feb 2014 17:28:43 +0100
From: Olaf Hering <olaf@aepfle.de>
Message-ID: <20140224162843.GA18456@aepfle.de>
References: <1391702379-20042-1-git-send-email-olaf@aepfle.de>
	<alpine.DEB.2.02.1402201803290.15812@kaball.uk.xensource.com>
	<20140220182057.GB19843@aepfle.de>
	<alpine.DEB.2.02.1402231511590.4471@kaball.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1402231511590.4471@kaball.uk.xensource.com>
Subject: Re: [Qemu-devel] [PATCH v2] xen_disk: add discard support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Sun, Feb 23, Stefano Stabellini wrote:

> Given that 4.2 is the first Xen release to have BLKIF_OP_DISCARD, maybe
> we could just #define BLKIF_OP_DISCARD 5 in that case?
> Do we actually need to #ifndef BLKIF_OP_DISCARD?

I will do just the #define and resend with that change.

Olaf