All of lore.kernel.org
 help / color / mirror / Atom feed
From: Venkatesh Srinivas <venkateshs@google.com>
To: linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, pbonzini@redhat.com, nab@linux-iscsi.org
Subject: [PATCH] vhost/scsi: Check LUN structure byte 0 is set to 1, per spec
Date: Mon, 24 Feb 2014 14:13:32 -0800	[thread overview]
Message-ID: <20140224221332.GA32725@google.com> (raw)

The virtio spec requires byte 0 of the virtio-scsi LUN structure
to be '1'.

Signed-off-by: Venkatesh Srinivas <venkateshs@google.com>
---
  drivers/vhost/scsi.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 0a025b8..e48d4a6 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1001,6 +1001,12 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq)
  			break;
  		}
  
+		/* virtio-scsi spec requires byte 0 of the lun to be 1 */
+		if (unlikely(v_req.lun[0] != 1)) {
+			vhost_scsi_send_bad_target(vs, vq, head, out);
+			continue;
+		}
+
  		/* Extract the tpgt */
  		target = v_req.lun[1];
  		tpg = ACCESS_ONCE(vs_tpg[target]);
-- 
1.8.5.3

             reply	other threads:[~2014-02-24 22:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 22:13 Venkatesh Srinivas [this message]
2014-02-24 22:27 ` [PATCH] vhost/scsi: Check LUN structure byte 0 is set to 1, per spec Paolo Bonzini
2014-02-25  0:16 ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140224221332.GA32725@google.com \
    --to=venkateshs@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.