All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: devel@driverdev.osuosl.org, paul.gortmaker@windriver.com,
	dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
	ufimtseva@gmail.com
Subject: Re: [PATCH v2] staging: ced401: fix double unlock bug
Date: Mon, 24 Feb 2014 16:43:57 -0800	[thread overview]
Message-ID: <20140225004357.GA28255@kroah.com> (raw)
In-Reply-To: <6036697.Bsd6uoTeJ1@daeseok-laptop.cloud.net>

On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
> 
> After spin_lock() is called, all of if-else conditions in this brace
> should reach the end of else and spin_unlock() must be called.
> So It doesn't need to call spin_unlock() without a return statement
> for handling an error.
> 
> Also sparse says:
> drivers/staging/ced1401/usb1401.c:1080:28: warning:
>  context imbalance in 'Handle1401Esc' - unexpected unlock
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>

This patch doesn't apply to my tree, can you please redo it against
linux-next and resend it so that I can apply it?

thanks,

greg k-h

  parent reply	other threads:[~2014-02-25  0:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 10:23 [PATCH v2] staging: ced401: fix double unlock bug Daeseok Youn
2014-02-24 10:31 ` Dan Carpenter
2014-02-25  0:43 ` Greg KH [this message]
2014-02-25  1:00   ` DaeSeok Youn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140225004357.GA28255@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=daeseok.youn@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=ufimtseva@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.