From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v8 01/14] mfd: omap-usb-host: Get clocks based on hardware revision Date: Tue, 25 Feb 2014 09:37:59 +0000 Message-ID: <20140225093759.GA22755@lee--X1> References: <1392896409-5101-1-git-send-email-rogerq@ti.com> <1392896409-5101-2-git-send-email-rogerq@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1392896409-5101-2-git-send-email-rogerq@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Roger Quadros Cc: nm@ti.com, devicetree@vger.kernel.org, khilman@linaro.org, Samuel Ortiz , tony@atomide.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@ti.com, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org PiBOb3QgYWxsIHJldmlzaW9ucyBoYXZlIGFsbCB0aGUgY2xvY2tzIHNvIGdldCB0aGUgbmVjZXNz YXJ5IGNsb2Nrcwo+IGJhc2VkIG9uIGhhcmR3YXJlIHJldmlzaW9uLgo+IAo+IFRoaXMgc2hvdWxk IGF2b2lkIHVuLW5lY2Vzc2FyeSBjbGtfZ2V0IGZhaWx1cmUgbWVzc2FnZXMgdGhhdCB3ZXJlCj4g b2JzZXJ2ZWQgZWFybGllci4KPiAKPiBDQzogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9y Zz4KPiBDQzogU2FtdWVsIE9ydGl6IDxzYW1lb0BsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9m Zi1ieTogUm9nZXIgUXVhZHJvcyA8cm9nZXJxQHRpLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tZmQv b21hcC11c2ItaG9zdC5jIHwgNDMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25z KC0pCgpXaGF0IGFib3V0IHBhdGNoZXMgMSBhbmQgMi4gQXJlIHRoZXNlIHNhZmUgdG8gZ28gaW4g YWxvbmU/CgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBU ZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0Nz CkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 25 Feb 2014 09:37:59 +0000 Subject: [PATCH v8 01/14] mfd: omap-usb-host: Get clocks based on hardware revision In-Reply-To: <1392896409-5101-2-git-send-email-rogerq@ti.com> References: <1392896409-5101-1-git-send-email-rogerq@ti.com> <1392896409-5101-2-git-send-email-rogerq@ti.com> Message-ID: <20140225093759.GA22755@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > Not all revisions have all the clocks so get the necessary clocks > based on hardware revision. > > This should avoid un-necessary clk_get failure messages that were > observed earlier. > > CC: Lee Jones > CC: Samuel Ortiz > Signed-off-by: Roger Quadros > --- > drivers/mfd/omap-usb-host.c | 43 ++++++++++++++++++++++++++++++++----------- > 1 file changed, 32 insertions(+), 11 deletions(-) What about patches 1 and 2. Are these safe to go in alone? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071AbaBYJiK (ORCPT ); Tue, 25 Feb 2014 04:38:10 -0500 Received: from mail-we0-f182.google.com ([74.125.82.182]:47251 "EHLO mail-we0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752719AbaBYJiG (ORCPT ); Tue, 25 Feb 2014 04:38:06 -0500 Date: Tue, 25 Feb 2014 09:37:59 +0000 From: Lee Jones To: Roger Quadros Cc: tony@atomide.com, bcousson@baylibre.com, balbi@ti.com, nm@ti.com, khilman@linaro.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH v8 01/14] mfd: omap-usb-host: Get clocks based on hardware revision Message-ID: <20140225093759.GA22755@lee--X1> References: <1392896409-5101-1-git-send-email-rogerq@ti.com> <1392896409-5101-2-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1392896409-5101-2-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Not all revisions have all the clocks so get the necessary clocks > based on hardware revision. > > This should avoid un-necessary clk_get failure messages that were > observed earlier. > > CC: Lee Jones > CC: Samuel Ortiz > Signed-off-by: Roger Quadros > --- > drivers/mfd/omap-usb-host.c | 43 ++++++++++++++++++++++++++++++++----------- > 1 file changed, 32 insertions(+), 11 deletions(-) What about patches 1 and 2. Are these safe to go in alone? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog