From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ben Segall <bsegall@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: put rq's sched_avg under CONFIG_FAIR_GROUP_SCHED
Date: Tue, 25 Feb 2014 18:46:42 +0530 [thread overview]
Message-ID: <20140225131642.GA3265@linux.vnet.ibm.com> (raw)
In-Reply-To: <1393328862-19997-1-git-send-email-dietmar.eggemann@arm.com>
> The struct sched_avg of struct rq is only used in case group
> scheduling is enabled inside __update_tg_runnable_avg() to update
> per-cpu representation of a task group. I.e. that there is no need to
> maintain the runnable avg of a rq in the !CONFIG_FAIR_GROUP_SCHED case.
>
> This patch guards struct sched_avg of struct rq and
> update_rq_runnable_avg() with CONFIG_FAIR_GROUP_SCHED.
>
While this patch looks good, I see fields in sched_avg viz decay_count,
last_runnable_update, load_avg_contrib only relevant to sched_entity.
i.e they don't seem to be updated or used for rq->avg. Should we look at
splitting sched_avg so that rq->avg doesn't have unwanted fields?
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2014-02-25 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 11:47 [PATCH] sched: put rq's sched_avg under CONFIG_FAIR_GROUP_SCHED Dietmar Eggemann
2014-02-25 13:16 ` Srikar Dronamraju [this message]
2014-02-25 17:47 ` Dietmar Eggemann
2014-02-25 19:55 ` bsegall
2014-02-25 20:52 ` Peter Zijlstra
2014-02-26 11:19 ` Dietmar Eggemann
2014-02-26 13:16 ` Peter Zijlstra
2014-02-26 17:53 ` bsegall
2014-02-27 13:32 ` [tip:sched/core] sched: Put rq' s " tip-bot for Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225131642.GA3265@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.