From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: KVM: x86: emulator_cmpxchg_emulated should mark_page_dirty Date: Tue, 25 Feb 2014 22:51:43 -0300 Message-ID: <20140226015142.GA26405@amt.cnet> References: <20140226014454.GA25423@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , Xiao Guangrong To: kvm-devel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15459 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbaBZBv6 (ORCPT ); Tue, 25 Feb 2014 20:51:58 -0500 Content-Disposition: inline In-Reply-To: <20140226014454.GA25423@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Feb 25, 2014 at 10:44:54PM -0300, Marcelo Tosatti wrote: > > emulator_cmpxchg_emulated writes to guest memory, therefore it should > updated the dirty bitmap accordingly. s/updated/update/ > > Signed-off-by: Marcelo Tosatti > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 39c28f09..29db96d 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -4394,6 +4394,7 @@ static int emulator_cmpxchg_emulated(struct x86_emulate_ctxt *ctxt, > if (!exchanged) > return X86EMUL_CMPXCHG_FAILED; > > + mark_page_dirty(vcpu->kvm, gpa >> PAGE_SHIFT); > kvm_mmu_pte_write(vcpu, gpa, new, bytes); > > return X86EMUL_CONTINUE; > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html