From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
bergwolf@gmail.com, andreas.dilger@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: make functions as static
Date: Wed, 26 Feb 2014 12:20:50 +0300 [thread overview]
Message-ID: <20140226092050.GO26722@mwanda> (raw)
In-Reply-To: <3395735.omIA0Togio@daeseok-laptop.cloud.net>
On Wed, Feb 26, 2014 at 06:17:59PM +0900, Daeseok Youn wrote:
>
> These functions are only referenced in this file scope
> so it can be marked static.
> And remove space between function name and open parenthesis.
If it's on the same line as a "static" change then it's fine, otherwise
it should go in a separate patch.
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-26 9:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 9:17 [PATCH] staging: lustre: make functions as static Daeseok Youn
2014-02-26 9:20 ` Dan Carpenter [this message]
2014-02-26 11:11 ` DaeSeok Youn
2014-02-26 11:31 ` Dan Carpenter
2014-02-26 11:41 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226092050.GO26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.