All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin.Marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: arm64 cache maintenance on read only address loops forever
Date: Wed, 26 Feb 2014 14:03:01 +0000	[thread overview]
Message-ID: <20140226140301.GB7761@arm.com> (raw)
In-Reply-To: <530D74C2.4000402@codeaurora.org>

On Tue, Feb 25, 2014 at 08:59:46PM -0800, Laura Abbott wrote:
> On arm64, set_pte_at currently write protects user ptes that are not
> dirty. The expected behavior is that the fault handler will fix this
> up on a write to the address. do_page_fault will not mark the fault
> as a write though if ESR has the CM (cache maintenance) bit set.
> This has the unfortunate side effect that if cache maintenance is
> performed on a user address that has not yet been marked as dirty,
> handle_mm_fault may return without actually adjusting the pte or
> returning an error. This means that the fault will be infinitely
> retried.
> 
> Calling cache maintenance on an address that hasn't actually been
> written to isn't all that useful but looping forever seems like a
> poor result. It seems like the check in do_page_fault is too
> restrictive and we need to be able to fault in pages via cache
> maintenance.

Which kernel are you using? We had a fix in this area, commit
db6f41063cbdb58b14846e600e6bc3f4e4c2e888 (arm64: mm: don't treat user
cache maintenance faults as writes).

-- 
Catalin

  parent reply	other threads:[~2014-02-26 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26  4:59 arm64 cache maintenance on read only address loops forever Laura Abbott
2014-02-26 13:55 ` Will Deacon
2014-02-26 21:40   ` Laura Abbott
2014-02-27 18:15     ` Will Deacon
2014-02-26 14:03 ` Catalin Marinas [this message]
2014-02-26 22:00   ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140226140301.GB7761@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.