All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	cpufreq@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] drivers: cpufreq: Remove unused function in cpufreq.c
Date: Wed, 26 Feb 2014 08:13:26 -0800	[thread overview]
Message-ID: <20140226161325.GA17358@thin> (raw)
In-Reply-To: <20140226154625.GA10701@rashika>

On Wed, Feb 26, 2014 at 09:16:25PM +0530, Rashika Kheria wrote:
> Remove unused function show_boost() in drivers/cpufreq/cpufreq.c.
> 
> This eliminates the following warning in drivers/cpufreq/cpufreq.c:
> drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/cpufreq/cpufreq.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 08ca8c9..6dce474 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -352,12 +352,6 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
>  /*********************************************************************
>   *                          SYSFS INTERFACE                          *
>   *********************************************************************/
> -ssize_t show_boost(struct kobject *kobj,
> -				 struct attribute *attr, char *buf)
> -{
> -	return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled);
> -}
> -
>  static ssize_t store_boost(struct kobject *kobj, struct attribute *attr,
>  				  const char *buf, size_t count)
>  {
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2014-02-26 16:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 15:46 [PATCH] drivers: cpufreq: Remove unused function in cpufreq.c Rashika Kheria
2014-02-26 16:13 ` Josh Triplett [this message]
2014-02-26 16:42 ` [PATCH v3] drivers: cpufreq: Mark function as static " Rashika Kheria
2014-02-26 21:56   ` Rafael J. Wysocki
2014-02-26 22:16     ` josh
2014-02-27  0:07       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140226161325.GA17358@thin \
    --to=josh@joshtriplett.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rashika.kheria@gmail.com \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.