From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, schwidefsky@de.ibm.com,
rientjes@google.com, riel@redhat.com, pbonzini@redhat.com,
mingo@kernel.org, mgorman@suse.de,
kirill.shutemov@linux.intel.com, heiko.carstens@de.ibm.com,
hannes@cmpxchg.org, gerald.schaefer@de.ibm.com,
ebiederm@xmission.com, aarcange@redhat.com, athorlton@sgi.com
Subject: Re: + mm-revert-thp-make-madv_hugepage-check-for-mm-def_flags.patch added to -mm tree
Date: Wed, 26 Feb 2014 19:08:07 +0100 [thread overview]
Message-ID: <20140226180807.GB25644@redhat.com> (raw)
In-Reply-To: <20140226165759.GB22802@laptop.programming.kicks-ass.net>
On 02/26, Peter Zijlstra wrote:
>
> On Wed, Feb 26, 2014 at 04:31:44PM +0100, Oleg Nesterov wrote:
> > /*
> > @@ -1977,8 +1975,12 @@ int hugepage_madvise(struct vm_area_stru
> > */
> > if (*vm_flags & (VM_HUGEPAGE | VM_NO_THP))
> > return -EINVAL;
> > - if (mm->def_flags & VM_NOHUGEPAGE)
> > +
> > +#ifdef CONFIG_S390
>
> Do we want a comment here, explaining why s390 is special again?
Yes, yes, sure. Especially because this is (hopefully) the temporary
hack.
Oleg.
prev parent reply other threads:[~2014-02-26 18:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 23:53 + mm-revert-thp-make-madv_hugepage-check-for-mm-def_flags.patch added to -mm tree akpm
[not found] ` <530D9F50.1080400@de.ibm.com>
2014-02-26 14:50 ` Oleg Nesterov
2014-02-26 15:06 ` Christian Borntraeger
2014-02-26 15:22 ` Kirill A. Shutemov
2014-02-26 15:31 ` Oleg Nesterov
2014-02-26 16:55 ` Gerald Schaefer
2014-02-26 16:57 ` Peter Zijlstra
2014-02-26 17:22 ` Alex Thorlton
2014-02-26 18:06 ` Oleg Nesterov
2014-02-26 19:05 ` Gerald Schaefer
2014-02-27 16:45 ` Oleg Nesterov
2014-02-26 19:27 ` Christian Borntraeger
2014-02-26 19:39 ` Alex Thorlton
2014-02-26 23:24 ` Andrew Morton
2014-02-27 0:01 ` Alex Thorlton
2014-02-27 17:26 ` Alex Thorlton
2014-02-26 20:41 ` Paolo Bonzini
2014-02-27 16:34 ` Oleg Nesterov
2014-02-26 18:08 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226180807.GB25644@redhat.com \
--to=oleg@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=athorlton@sgi.com \
--cc=borntraeger@de.ibm.com \
--cc=ebiederm@xmission.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=heiko.carstens@de.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=schwidefsky@de.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.