All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract
Date: Wed, 26 Feb 2014 22:48:52 +0100	[thread overview]
Message-ID: <20140226214852.GB16780@free.fr> (raw)
In-Reply-To: <530E5DAE.8030609@mind.be>

Arnout, All,

On 2014-02-26 22:33 +0100, Arnout Vandecappelle spake thusly:
> On 26/02/14 19:40, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> > ti-gfx uses custom extract commands, which first and foremost removes
> > the source dir unconditionally.
> > 
> > Thee side-effect of this is that make will re-extract, re-patch and
> > probably re-build ti-gfx at each run.
> 
>  There actually was a reason for this - I think the extract fails if you
> re-run it. Have you tried
> 
> make ti-gfx-extract; make ti-gfx-extract

I shall try that right away... Nope, works!

I eventually understood what was going on. Basically, when you run:

    make ti-gfx-extract

under the hood, it's as you did:

    make ti-gfx-source
    make ti-gfx-extract

But -source creates a stamp file. Then -extract would remove the
directory, thus removing the stamp file.

10 When you run make again, the stamp file for the download is missing, so
make tries to download it again (invisible, since we already have the
archive), creates the stamp file, and extract again, which removes the
stamp file.
20 GOTO 10.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      parent reply	other threads:[~2014-02-26 21:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 18:40 [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract Yann E. MORIN
2014-02-26 20:51 ` Peter Korsgaard
2014-02-26 21:33 ` Arnout Vandecappelle
2014-02-26 21:43   ` Peter Korsgaard
2014-02-26 21:50     ` Arnout Vandecappelle
2014-02-26 21:48   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140226214852.GB16780@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.