From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 26 Feb 2014 17:03:08 -0500 Subject: [U-Boot] [PATCH 8/8] arm64: Do not double -mstrict-align option In-Reply-To: <20140226225810.55e66807@lilith> References: <1393393865-11608-1-git-send-email-yamada.m@jp.panasonic.com> <1393393865-11608-9-git-send-email-yamada.m@jp.panasonic.com> <20140226135543.GX16805@bill-the-cat> <20140226225810.55e66807@lilith> Message-ID: <20140226220308.GF16805@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 26, 2014 at 10:58:10PM +0100, Albert ARIBAUD wrote: > Hi Tom, > > On Wed, 26 Feb 2014 08:55:43 -0500, Tom Rini wrote: > > > On Wed, Feb 26, 2014 at 02:51:05PM +0900, Masahiro Yamada wrote: > > > > > Seeing arch/arm/cpu/armv8/config.mk, -mstrict-align option > > > was added to both PLATFORM_NO_UNALIGNED and PLATFORM_CPPFLAGS. > > > > > > $(PLATFORM_CPPFLAGS) is given to all compiled objects. > > > Adding the same option to also PLATFORM_NO_UNALIGNED is > > > redundant. > > > > > > For example, common/hush.o was compiled with double -mstrict-align. > > > You can comfirm it by checking common/.hush.o.cmd file. > > > > > > Signed-off-by: Masahiro Yamada > > > Cc: David Feng > > > Cc: Albert ARIBAUD > > > Cc: Tom Rini > > > > With the v3 series about unaligned bits this patch should no longer be > > needed. > > Hmm... This patch is about not repeating -mstrict-align twice, which is > a bug unrelated with switching to -mno-unaligned-access. > > Besides, -mstrict-align means "Don't assume that unaligned accesses are > handled", which I think is for aarch64 what -mno-unaligned-access is > for arm(32), so it *should* be specified. Yes, but my patch cleaned up the places that set PLATFORM_NO_UNALIGNED so this duplication was dropped. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: