From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/2] xfs_logprint: Don't error out after split items lose context
Date: Thu, 27 Feb 2014 12:27:55 +1100 [thread overview]
Message-ID: <20140227012755.GX13647@dastard> (raw)
In-Reply-To: <530E9135.2020807@sandeen.net>
On Wed, Feb 26, 2014 at 07:13:25PM -0600, Eric Sandeen wrote:
> xfs_logprint recognizes a "left over region from split log item"
> but then expects the *next* op to be a valid start to a new
> item. The problem is, we can split i.e. an xfs_inode_log_format
> item, skip over it, and then land on the xfs_icdinode_t
> data which follows it - this doesn't have a valid log item
> magic (XFS_LI_*) and we error out. This results in something
> like:
>
> xfs_logprint: unknown log operation type (494e)
>
> Fix this by recognizing that we've skipped over an item and
> lost the context we're in, so just continue skipping over
> op headers until we find the next valid start to a log item.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good - fixes the problem and does a good job of explaining it.
:)
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-27 1:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 1:00 [PATCH 0/2] xfs_logprint: Get xfstests/xfs/295 passing w/ CRCs Eric Sandeen
2014-02-27 1:13 ` [PATCH 1/2] xfs_logprint: Don't error out after split items lose context Eric Sandeen
2014-02-27 1:27 ` Dave Chinner [this message]
2014-02-27 1:15 ` [PATCH 2/2] xfs_logprint: don't advance op counter in xlog_print_trans_icreate Eric Sandeen
2014-02-27 1:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227012755.GX13647@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.