From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 1/8] mfd: Move pm8xxx-irq.c contents into only driver that uses it Date: Thu, 27 Feb 2014 08:33:39 +0000 Message-ID: <20140227083339.GU9195@lee--X1> References: <1393441166-32692-1-git-send-email-sboyd@codeaurora.org> <1393441166-32692-2-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f49.google.com ([74.125.82.49]:34593 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbaB0Idq (ORCPT ); Thu, 27 Feb 2014 03:33:46 -0500 Received: by mail-wg0-f49.google.com with SMTP id x12so2566020wgg.8 for ; Thu, 27 Feb 2014 00:33:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <1393441166-32692-2-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org > The pm8xxx-irq.c code is practically mandatory given that the > pm8921-core driver will WARN about it missing and the Kconfig > marks it as default y when a PM8xxx chips is enabled. The only > reason the file was split out was because we planned to support > other pm8xxx chips with different pm8xxx-core.c files. Now that > we have DT on ARM this isn't necessary because we should be able > to support all the ssbi based PM8xxx chips in one driver and one > file with no data bloat. Let's move this code into the only > driver that uses it right now (pm8921) so that it's always compiled w= hen > needed. In the future we can rename pm8921-core.c to something > more generic. >=20 > Acked-by: Lee Jones > Signed-off-by: Stephen Boyd > --- > drivers/mfd/Kconfig | 10 -- > drivers/mfd/Makefile | 1 - > drivers/mfd/pm8921-core.c | 348 +++++++++++++++++++++++++++++++= +++++++ > drivers/mfd/pm8xxx-irq.c | 371 -------------------------------= ---------- > include/linux/mfd/pm8xxx/irq.h | 23 --- > 5 files changed, 348 insertions(+), 405 deletions(-) > delete mode 100644 drivers/mfd/pm8xxx-irq.c Applied, thanks. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 27 Feb 2014 08:33:39 +0000 Subject: [PATCH v4 1/8] mfd: Move pm8xxx-irq.c contents into only driver that uses it In-Reply-To: <1393441166-32692-2-git-send-email-sboyd@codeaurora.org> References: <1393441166-32692-1-git-send-email-sboyd@codeaurora.org> <1393441166-32692-2-git-send-email-sboyd@codeaurora.org> Message-ID: <20140227083339.GU9195@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > The pm8xxx-irq.c code is practically mandatory given that the > pm8921-core driver will WARN about it missing and the Kconfig > marks it as default y when a PM8xxx chips is enabled. The only > reason the file was split out was because we planned to support > other pm8xxx chips with different pm8xxx-core.c files. Now that > we have DT on ARM this isn't necessary because we should be able > to support all the ssbi based PM8xxx chips in one driver and one > file with no data bloat. Let's move this code into the only > driver that uses it right now (pm8921) so that it's always compiled when > needed. In the future we can rename pm8921-core.c to something > more generic. > > Acked-by: Lee Jones > Signed-off-by: Stephen Boyd > --- > drivers/mfd/Kconfig | 10 -- > drivers/mfd/Makefile | 1 - > drivers/mfd/pm8921-core.c | 348 ++++++++++++++++++++++++++++++++++++++ > drivers/mfd/pm8xxx-irq.c | 371 ----------------------------------------- > include/linux/mfd/pm8xxx/irq.h | 23 --- > 5 files changed, 348 insertions(+), 405 deletions(-) > delete mode 100644 drivers/mfd/pm8xxx-irq.c Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog