From: "Dr. David Alan Gilbert" <dave@treblig.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: The sheer number of sparse warnings in the kernel
Date: Thu, 27 Feb 2014 09:56:35 +0000 [thread overview]
Message-ID: <20140227095635.GA1816@gallifrey> (raw)
In-Reply-To: <530E6F76.1070605@zytor.com>
* H. Peter Anvin (hpa@zytor.com) wrote:
> The number of sparse errors in the current kernel is staggering, and it
> makes sparse a lot less valuable of a tool that it otherwise could be.
> On a build of x86-64 allyesconfig I'm getting 20,676 sparse messages.
> Out of those, 12,358 come from linux/err.h. Given that the latter
> basically spams *everything*, I can only conclude that almost noone uses
> sparse unless they have a filter script.
I did a bit of sparse fixing a few years ago; my strategy then was to
get used to which types of warnings were more likely to be real
and ignore all the rest - it was the only way to find anything useful from
them.
There were some that were very fruitful; the warnings for gfp_t types were
great at spotting where someone had swapped the parameters to kmalloc
for example.
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2014-02-27 10:37 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 22:49 The sheer number of sparse warnings in the kernel H. Peter Anvin
2014-02-26 23:25 ` Borislav Petkov
2014-02-27 8:27 ` Richard Weinberger
2014-02-26 23:28 ` Greg KH
2014-02-26 23:29 ` Greg KH
2014-02-26 23:31 ` H. Peter Anvin
2014-02-26 23:37 ` H. Peter Anvin
2014-02-27 1:19 ` Josh Boyer
2014-02-27 1:21 ` H. Peter Anvin
2014-03-04 23:13 ` Valdis.Kletnieks
2014-02-27 0:11 ` H. Peter Anvin
2014-02-27 1:34 ` Greg KH
2014-02-27 2:09 ` Joe Perches
2014-02-27 3:15 ` Dave Jones
2014-02-27 4:32 ` Greg KH
2014-02-27 10:11 ` Guenter Roeck
2014-02-27 1:52 ` Peter Hurley
2014-02-27 4:19 ` H. Peter Anvin
2014-02-27 4:31 ` Greg KH
2014-02-27 9:22 ` Geert Uytterhoeven
2014-02-27 0:48 ` Joe Perches
2014-02-27 0:51 ` H. Peter Anvin
2014-02-27 1:06 ` Joe Perches
2014-02-27 1:33 ` [PATCH] err.h: Use bool for IS_ERR and IS_ERR_OR_NULL Joe Perches
2014-02-27 2:03 ` [PATCH] sparse: Allow override of sizeof(bool) warning Joe Perches
2014-02-27 2:08 ` [RFC PATCH] Makefile: sparse - don't check sizeof(bool) Joe Perches
2014-02-27 2:28 ` [PATCH] sparse: Allow override of sizeof(bool) warning Josh Triplett
2014-02-27 2:53 ` [PATCH V2] " Joe Perches
2014-02-27 2:58 ` Josh Triplett
2014-02-27 3:19 ` [PATCH V3] " Joe Perches
2014-02-27 3:29 ` [PATCH V2] " H. Peter Anvin
2014-02-27 3:38 ` Joe Perches
2014-02-27 3:42 ` H. Peter Anvin
2014-02-27 8:25 ` Borislav Petkov
2014-02-27 15:10 ` H. Peter Anvin
2014-02-27 15:24 ` Theodore Ts'o
2014-02-27 15:48 ` H. Peter Anvin
2014-02-27 16:01 ` Borislav Petkov
2014-02-27 16:10 ` Dan Carpenter
2014-02-27 16:52 ` H. Peter Anvin
2014-02-27 17:06 ` James Hogan
2014-02-27 17:06 ` James Hogan
2014-02-27 4:00 ` Ben Pfaff
2014-02-27 4:19 ` H. Peter Anvin
2014-02-27 4:26 ` Ben Pfaff
2014-02-27 4:32 ` H. Peter Anvin
2014-02-27 20:22 ` Christopher Li
2014-02-27 20:26 ` H. Peter Anvin
2014-02-27 20:39 ` Joe Perches
2014-02-27 20:55 ` Christopher Li
2014-02-27 21:49 ` Joe Perches
2014-02-27 20:44 ` Christopher Li
2014-02-27 21:00 ` Joe Perches
2014-02-27 21:03 ` Christopher Li
2014-02-27 21:41 ` Christopher Li
2014-02-27 9:56 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227095635.GA1816@gallifrey \
--to=dave@treblig.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.