All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: David Miller <davem@redhat.com>
Cc: alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
	linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	martin.townsend@xsilon.com
Subject: Re: [PATCH net-next v5 8/8] 6lowpan: handling 6lowpan fragmentation via inet_frag api
Date: Thu, 27 Feb 2014 22:16:54 +0100	[thread overview]
Message-ID: <20140227211652.GA29339@omega> (raw)
In-Reply-To: <20140227.155639.1203195193096437286.davem@redhat.com>

Hi David,

On Thu, Feb 27, 2014 at 03:56:39PM -0500, David Miller wrote:
> From: Alexander Aring <alex.aring@gmail.com>
> Date: Thu, 27 Feb 2014 09:06:22 +0100
> 
> > +static int lowpan_frag_queue(struct lowpan_frag_queue *fq,
> > +			     struct sk_buff *skb, const u8 frag_type,
> > +			     const struct ieee802154_frag_info *frag_info)
> 
> The 'frag_info' argument is unused.  You always explicitly access
> mac_cb()->frag_info here.

You are absolutly right, sorry for that. I will remove this parameter
instead of using frag_info than mac_cb(skb)->frag_info... because I
compare with some other sk buffs like mac(next)->frag_info. This will be
more easier to read.

Thanks.

- Alex

      reply	other threads:[~2014-02-27 21:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27  8:06 [PATCH net-next v5 0/8] 6lowpan: reimplementation of fragmentation handling Alexander Aring
2014-02-27  8:06 ` [PATCH net-next v5 2/8] 6lowpan: add uncompress header size function Alexander Aring
     [not found] ` <1393488382-1250-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-27  8:06   ` [PATCH net-next v5 1/8] 6lowpan: add frag information struct Alexander Aring
2014-02-27  8:06   ` [PATCH net-next v5 3/8] 6lowpan: fix fragmentation on sending side Alexander Aring
2014-02-27  8:06   ` [PATCH net-next v5 5/8] 6lowpan: move 6lowpan.c to 6lowpan_rtnl.c Alexander Aring
2014-02-27  8:06   ` [PATCH net-next v5 6/8] 6lowpan: fix some checkpatch issues Alexander Aring
2014-02-27  8:06 ` [PATCH net-next v5 4/8] 6lowpan: change tag type to __be16 Alexander Aring
2014-02-27  8:06 ` [PATCH net-next v5 7/8] net: ns: add ieee802154_6lowpan namespace Alexander Aring
2014-02-27  8:06 ` [PATCH net-next v5 8/8] 6lowpan: handling 6lowpan fragmentation via inet_frag api Alexander Aring
2014-02-27 20:56   ` David Miller
2014-02-27 21:16     ` Alexander Aring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140227211652.GA29339@omega \
    --to=alex.aring@gmail.com \
    --cc=alex.bluesman.smirnov@gmail.com \
    --cc=davem@redhat.com \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-zigbee-devel@lists.sourceforge.net \
    --cc=martin.townsend@xsilon.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.