From: Masood Mehmood <ody.guru@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Omar Ramirez Luna <omar.ramirez@copitl.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:tidspbridge: Fixing coding style
Date: Fri, 28 Feb 2014 00:30:04 -0800 [thread overview]
Message-ID: <20140228083003.GA1944@localhost.localdomain> (raw)
In-Reply-To: <20140301030156.GA17472@kroah.com>
On Fri, Feb 28, 2014 at 07:01:56PM -0800, Greg Kroah-Hartman wrote:
> On Fri, Feb 28, 2014 at 06:15:52PM -0800, Masood Mehmood wrote:
> >
>
> >
> > Fixing some basic coding style issues.
>
> Which issues did you fix? Please be more specific. Did you fix them
> for the whole driver, or just a specific file?
- Unnecessary line break and space.
- and some * adjusted to the data name
- Removed braces for single statement if conditions.
I just realized, other files of the same driver also need some style fixes.
I'll send another patch with reset of the files included.
>
> And what's with the odd multiple attachments?
Sorry, new to mutt.
>
> thanks,
>
> greg k-h
Thanks,
Masood
next prev parent reply other threads:[~2014-03-01 3:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 2:15 [PATCH] Staging:tidspbridge: Fixing coding style Masood Mehmood
2014-03-01 3:01 ` Greg Kroah-Hartman
2014-02-28 8:30 ` Masood Mehmood [this message]
2014-03-01 4:09 ` Greg Kroah-Hartman
2014-03-01 9:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228083003.GA1944@localhost.localdomain \
--to=ody.guru@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=omar.ramirez@copitl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.