All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Josh Hunt <johunt@akamai.com>
Cc: netfilter-devel@vger.kernel.org, kadlec@blackhole.kfki.hu
Subject: Re: [PATCH v2 2/2] ipset: add userspace support for forceadd
Date: Fri, 28 Feb 2014 10:25:14 +0100	[thread overview]
Message-ID: <20140228092514.GA4011@localhost> (raw)
In-Reply-To: <1393542286-20955-3-git-send-email-johunt@akamai.com>

On Thu, Feb 27, 2014 at 06:04:46PM -0500, Josh Hunt wrote:
> The userspace side of the forceadd changes.
> 
> Signed-off-by: Josh Hunt <johunt@akamai.com>
> ---
>  Make_global.am              |    2 +-
>  include/libipset/data.h     |    4 +-
>  lib/data.c                  |    6 ++
>  lib/ipset_hash_ip.c         |  123 +++++++++++++++++++++++++++++++
>  lib/ipset_hash_ipmark.c     |  142 ++++++++++++++++++++++++++++++++++++
>  lib/ipset_hash_ipport.c     |  147 +++++++++++++++++++++++++++++++++++++
>  lib/ipset_hash_ipportip.c   |  158 ++++++++++++++++++++++++++++++++++++++++
>  lib/ipset_hash_ipportnet.c  |  169 +++++++++++++++++++++++++++++++++++++++++++
>  lib/ipset_hash_net.c        |  119 ++++++++++++++++++++++++++++++
>  lib/ipset_hash_netiface.c   |  125 ++++++++++++++++++++++++++++++++
>  lib/ipset_hash_netnet.c     |  125 ++++++++++++++++++++++++++++++++
>  lib/ipset_hash_netport.c    |  132 +++++++++++++++++++++++++++++++++
>  lib/ipset_hash_netportnet.c |  149 ++++++++++++++++++++++++++++++++++++++
>  src/ipset.8                 |    7 ++
>  14 files changed, 1406 insertions(+), 2 deletions(-)
> 
> diff --git a/Make_global.am b/Make_global.am
> index f931618..1151714 100644
> --- a/Make_global.am
> +++ b/Make_global.am
> @@ -69,7 +69,7 @@
>  # interface. 
>  
>  #            curr:rev:age
> -LIBVERSION = 5:0:3
> +LIBVERSION = 6:0:1

I think this should be:

6:0:4 if you just added somes interfaces while retaining backward
compatibility.

or

6:0:0 if you removed interfaces (thus, backward compatibility is not
retained).

  reply	other threads:[~2014-02-28  9:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 23:04 [PATCH v2 0/2] ipset: forceadd support Josh Hunt
2014-02-27 23:04 ` [PATCH v2 1/2] ipset: add forceadd kernel support for hash set types Josh Hunt
2014-02-28 21:29   ` Jozsef Kadlecsik
2014-02-27 23:04 ` [PATCH v2 2/2] ipset: add userspace support for forceadd Josh Hunt
2014-02-28  9:25   ` Pablo Neira Ayuso [this message]
2014-02-28 21:46   ` Jozsef Kadlecsik
2014-02-28 21:52     ` Josh Hunt
2014-02-28  3:41 ` [PATCH v2 0/2] ipset: forceadd support Phil Oester
2014-02-28 14:26   ` Josh Hunt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140228092514.GA4011@localhost \
    --to=pablo@netfilter.org \
    --cc=johunt@akamai.com \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.