From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/3] PCI: imx6: fixup for add-in card IRQ mismapping
Date: Fri, 28 Feb 2014 11:15:50 +0100 [thread overview]
Message-ID: <201402281115.50917.marex@denx.de> (raw)
In-Reply-To: <000001cf344d$845edf90$8d1c9eb0$%han@samsung.com>
On Friday, February 28, 2014 at 07:22:52 AM, Jingoo Han wrote:
> On Friday, February 28, 2014 1:16 PM, Tim Harvey wrote:
> > On Thu, Feb 27, 2014 at 5:50 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> > > On Friday, February 28, 2014 10:20 AM, Tim Harvey wrote:
> > > > An add-in card used on the Ventana IMX6 SoC based family of boards
> > > > has a TI XIO2001 PCIe-to-PCI bridge where the INTA/B/C/D mappings
> > > > between the bridge and the four mini-PCI slots are swapped
> > > > (INTD/C/B/A).
> > >
> > > (+cc Marek Vasut, Pratyush Anand, Kishon Vijay Abraham I, Mohit KUMAR
> > > DCG)
> > >
> > > This problem happens from the 'Board', not a 'SoC'.
> > > 'TI XIO2001 PCIe-to-PCI bridge' is not a 'SoC'.
> > > 'pci-imx6.c' is the driver for 'IMX6 PCI IP', not for 'IMX6 SoC based
> > > board'. Isn't it?
> >
> > Jingoo,
> >
> > Correct, this is an issue in the way the XIO2001 was hooked up to the
> > PCI slots, so it should be viewed as a board issue.
>
> (+CC Arnd Bergmann)
>
> Then, this board fixup code should NOT be placed in './drivers/pci/host/'
> side.
>
> > > Then, the workaround code for board problem should NOT be
> > > included to './drivers/pci/host/' side.
> >
> > I would agree, but to overcome this sort of interrupt mapping issue
> > one would need to either implement a custom swizzle or perhaps a
> > custom map_irq and both of those are hooked into the pcie driver core.
> >
> > Do you have any suggestions on where/how I would better hook into
> >
> > those?
>
> Anyway, 'TI XIO2001 PCIe-to-PCI bridge' chip on the board is the
> culprit. So, the board specific side is a good place.
> For instance, ./arch/arm/mach-imx/
>
> I don't know how to handle this problem.
> But, there is no reason that 'pcie-designware.c' should take a care
> of the board specific issue.
Can you not just supply the INTA...INTD IRQ numbers in reverse order via DT for
this board ?
next prev parent reply other threads:[~2014-02-28 10:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 1:19 [RFC PATCH 0/3] PCI: imx6: fixup for add-in card IRQ mismapping Tim Harvey
2014-02-28 1:19 ` [PATCH 1/3] PCI: designware: add legacy PCI interrupt mapping Tim Harvey
2014-02-28 2:00 ` Jingoo Han
2014-02-28 4:24 ` Tim Harvey
2014-02-28 7:01 ` Jingoo Han
2014-02-28 10:12 ` Marek Vasut
2014-02-28 11:27 ` Lucas Stach
2014-02-28 11:37 ` Arnd Bergmann
2014-02-28 12:09 ` Lucas Stach
2014-02-28 12:27 ` Arnd Bergmann
2014-02-28 13:53 ` Lucas Stach
2014-02-28 2:10 ` Shawn Guo
2014-02-28 1:19 ` [PATCH 2/3] PCI: designware: add ability for custom swizzle Tim Harvey
2014-02-28 1:19 ` [PATCH 3/3] PCI: imx6: ventana: fixup for IRQ mismapping Tim Harvey
2014-02-28 2:10 ` Jingoo Han
2014-02-28 9:27 ` Arnd Bergmann
2014-02-28 17:39 ` Jason Gunthorpe
2014-03-01 0:52 ` Tim Harvey
2014-03-01 1:22 ` Jason Gunthorpe
2014-03-03 19:59 ` Tim Harvey
2014-03-03 23:37 ` Jason Gunthorpe
2014-03-04 0:38 ` Tim Harvey
2014-03-04 1:01 ` Jason Gunthorpe
2014-02-28 1:50 ` [RFC PATCH 0/3] PCI: imx6: fixup for add-in card " Jingoo Han
2014-02-28 4:16 ` Tim Harvey
2014-02-28 6:22 ` Jingoo Han
2014-02-28 10:15 ` Marek Vasut [this message]
2014-02-28 16:52 ` Tim Harvey
2014-02-28 16:55 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402281115.50917.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.