From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/3] drm/i915: Make num_sprites a per-pipe
 value
Date: Fri, 28 Feb 2014 20:15:38 +0200
Message-ID: <20140228181538.GT3852@intel.com>
References: <1393605735-7772-1-git-send-email-damien.lespiau@intel.com>
	<1393605735-7772-4-git-send-email-damien.lespiau@intel.com>
	<20140228173002.GE21275@nuc-i3427.alporthouse.com>
	<20140228173739.GA9964@strange.amr.corp.intel.com>
	<20140228174920.GF21275@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id EF115FA0E2
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 28 Feb 2014 10:15:43 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140228174920.GF21275@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Damien Lespiau <damien.lespiau@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Feb 28, 2014 at 05:49:20PM +0000, Chris Wilson wrote:
> On Fri, Feb 28, 2014 at 05:37:39PM +0000, Damien Lespiau wrote:
> > On Fri, Feb 28, 2014 at 05:30:02PM +0000, Chris Wilson wrote:
> > > On Fri, Feb 28, 2014 at 04:42:15PM +0000, Damien Lespiau wrote:
> > > > In the future, we need to be able to specify per-pipe number of
> > > > planes/sprites. Let's start today!
> > > =

> > > But today, what's wrong with:
> > > for_each_pipe(pipe) info->num_sprites[pipe] =3D IS_VLV(dev) ? 2 : 1;
> > =

> > I'd rather have info->num_sprites[pipe] =3D=3D 0 when the device doesn't
> > support that pipe, even if that value shouldn't be used anywhere.
> =

> for (; pipe < I915_NUM_PIPES; pipe++) info->num_sprites[pipe] =3D 0;

It should be zero initialized anyway, so we shouldn't need to do that.

-- =

Ville Syrj=E4l=E4
Intel OTC