From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] metadump: pathname obfuscation overruns symlink buffer
Date: Sat, 1 Mar 2014 10:28:16 +1100 [thread overview]
Message-ID: <20140228232816.GF13647@dastard> (raw)
In-Reply-To: <5310CAEB.8080503@sandeen.net>
On Fri, Feb 28, 2014 at 11:44:11AM -0600, Eric Sandeen wrote:
> On 2/28/14, 12:25 AM, Dave Chinner wrote:
> > diff --git a/db/metadump.c b/db/metadump.c
> > index 3248009..cd489a6 100644
> > --- a/db/metadump.c
> > +++ b/db/metadump.c
> > @@ -1015,16 +1015,23 @@ obfuscate_sf_dir(
> > }
> > }
> >
> > +/*
> > + * The pathname may not be null terminated. It name be terminated by the end of
>
> can you fix up the start of that 2nd sentence?
Done.
>
> Otherwise,
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Thanks!
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-28 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 6:25 [PATCH 0/3] metadump: fixes for obfuscated dumps Dave Chinner
2014-02-28 6:25 ` [PATCH 1/3] metadump: contiguous metadata object need to be split Dave Chinner
2014-02-28 17:52 ` Eric Sandeen
2014-02-28 6:25 ` [PATCH 2/3] metadump: Only verify obfuscated metadata being dumped Dave Chinner
2014-02-28 17:58 ` Eric Sandeen
2014-02-28 6:25 ` [PATCH 3/3] metadump: pathname obfuscation overruns symlink buffer Dave Chinner
2014-02-28 17:44 ` Eric Sandeen
2014-02-28 23:28 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228232816.GF13647@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.