From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: ensure system is built even if no filesystem image is selected
Date: Sat, 1 Mar 2014 12:54:10 +0100 [thread overview]
Message-ID: <20140301125410.0a8fc7ca@skate> (raw)
In-Reply-To: <1393617927-1661-1-git-send-email-thomas.petazzoni@free-electrons.com>
Dear Thomas Petazzoni,
On Fri, 28 Feb 2014 21:05:27 +0100, Thomas Petazzoni wrote:
> The parallel build patch series has significantly reworked how some of
> the core dependencies are expressed. We now have the following
> dependencies:
>
> all: world
> world: target-post-image
> target-post-image: $(TARGETS_ROOTFS)
>
> with TARGETS_ROOTFS containing the list of root filesystem image
> targets, each having the following dependencies:
>
> $$(BINARIES_DIR)/rootfs.$(1): target-finalize $$(ROOTFS_$(2)_DEPENDENCIES)
>
> The bottom line is that the "target-finalize" target, which in turns
> ensures that all packages are built, is only triggered if at least one
> filesystem image is enabled.
>
> As we want to support builds with no filesystem image selected, this
> is not acceptable. As a fix, we change the target-post-image target
> to:
>
> target-post-image: $(TARGETS_ROOTFS) target-finalize
>
> This way, target-finalize will be triggered even if TARGETS_ROOTFS is
> empty. This is still correct for parallel build, as the individual
> root filesystem image targets still depend on target-finalize.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-03-01 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 20:05 [Buildroot] [PATCH] Makefile: ensure system is built even if no filesystem image is selected Thomas Petazzoni
2014-02-28 20:07 ` Gustavo Zacarias
2014-02-28 22:29 ` Fabio Porcedda
2014-03-01 11:54 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140301125410.0a8fc7ca@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.