From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/17 v2] Add new virtual-package infrastructure
Date: Sat, 1 Mar 2014 23:56:18 +0100 [thread overview]
Message-ID: <20140301235618.04b363a8@skate> (raw)
In-Reply-To: <cover.1393695127.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sat, 1 Mar 2014 18:32:43 +0100, Yann E. MORIN wrote:
> package/libgles: rename the _HAS and _PROVIDES variables
> package/libegl: rename the _HAS and _PROVIDES variables
> package/libopenmax: rename the _HAS and _PROVIDES variables
> package/libopenvg: rename the _HAS and _PROVIDES variables
> package/luainterpreter: rename the _HAS and _PROVIDES variables
I certainly agree to ensure that the kconfig symbol matches the package
name. However, I am not sure the renaming of BR2_PACKAGE_HAS_OPENGL_ES
to BR2_PACKAGE_HAS_LIBGLES is really nice. BR2_PACKAGE_HAS_OPENGL_ES
had the merit of explicitly containing the word "OpenGL", while LIBGLES
makes that a bit more cryptic. Do we want to instead rename the package
to libopengl-es or some other variation on this?
A similar reflexion could be made on the naming of the libegl package.
Of course, I'm open to other opinions on this, the above comments are
not really a very strong opinion on my side.
My original plan was to apply patches 1 -> 6 of your series in order to
remove you a bunch of patches to handle, but I'm not sure about these
renames.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-01 22:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 17:32 [Buildroot] [PATCH 0/17 v2] Add new virtual-package infrastructure Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 01/17] package/libgles: rename the _HAS and _PROVIDES variables Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 02/17] package/libegl: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 03/17] package/libopenmax: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 04/17] package/libopenvg: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 05/17] package/luainterpreter: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 06/17] package/lua: rename config options Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 07/17] manual: add virtual package tutorial Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 08/17] packages: add infrastructure for virtual packages Yann E. MORIN
2014-03-01 19:25 ` Thomas De Schampheleire
2014-03-01 20:52 ` Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 09/17] manual: update the virtual package section with the new infra-structure Yann E. MORIN
2014-03-01 18:58 ` Samuel Martin
2014-03-01 20:53 ` Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 10/17] package/powervr: convert to the virtual-package infrastructure Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 11/17] package/libgles: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 12/17] package/libegl: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 13/17] package/libopenmax: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 14/17] package/libopenvg: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 15/17] package/luainterpreter: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 16/17] package/jpeg: " Yann E. MORIN
2014-03-01 17:32 ` [Buildroot] [PATCH 17/17] package/cryptodev: " Yann E. MORIN
2014-03-01 19:06 ` [Buildroot] [PATCH 0/17 v2] Add new " Samuel Martin
2014-03-02 16:48 ` Yann E. MORIN
2014-03-01 19:27 ` Thomas De Schampheleire
2014-03-01 20:54 ` Yann E. MORIN
2014-03-01 22:56 ` Thomas Petazzoni [this message]
2014-03-07 14:00 ` Eric Le Bihan
2014-03-07 17:12 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140301235618.04b363a8@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.