From: Alexander Aring <alex.aring@gmail.com>
To: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-zigbee-devel@lists.sourceforge.net
Subject: Re: [Linux-zigbee-devel] [PATCH 4/4] ieee802154: remove seq member of mac_cb
Date: Mon, 3 Mar 2014 15:10:27 +0100 [thread overview]
Message-ID: <20140303141026.GA22241@omega> (raw)
In-Reply-To: <20140303140601.GB24286@omega>
On Mon, Mar 03, 2014 at 03:06:01PM +0100, Alexander Aring wrote:
> Hi,
>
> This patch is fine. Increment and set of DSN value should be done by
> mac802154 layer.
>
> But there is also a known issue with increment of DSN value while
> 6lowpan fragmentation.
>
> On a fragmented packet 6lowpan calls dev_hard_header once, then many
> times lowpan_fragment_xmit, depending on the number of fragments which
> is needed.
>
> Each call of lowpan_fragment_xmit will have the same DSN value. Maybe we
> should put the increment of DSN in "mac802154/tx.c" before calling xmit
> callback from driver (Just an idea). What do you think about that?
>
Or maybe we can move the dev_hard_header call in lowpan_fragment_xmit
and lowpan_xmit if this is possible. But then we doesn't know the mac
header length in lowpan_skb_fragmentation. Strange...
- Alex
next prev parent reply other threads:[~2014-03-03 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 12:59 [PATCH net-next 0/4] ieee802154: clean up header handling Phoebe Buckheister
2014-03-03 12:59 ` [PATCH 1/4] ieee802154: add generic header handling routines Phoebe Buckheister
[not found] ` <1393851547-27876-1-git-send-email-phoebe.buckheister-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
2014-03-03 12:59 ` [PATCH 2/4] mac802154: use new header ops in wpan devices Phoebe Buckheister
2014-03-03 12:59 ` [PATCH 3/4] ieee802154: remove addresses from mac_cb Phoebe Buckheister
2014-03-03 12:59 ` [PATCH 4/4] ieee802154: remove seq member of mac_cb Phoebe Buckheister
2014-03-03 14:06 ` [Linux-zigbee-devel] " Alexander Aring
2014-03-03 14:10 ` Alexander Aring [this message]
2014-03-03 14:34 ` Phoebe Buckheister
2014-03-03 14:12 ` Phoebe Buckheister
2014-03-03 15:40 ` Alexander Aring
2014-03-03 13:59 ` [PATCH net-next 0/4] ieee802154: clean up header handling Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303141026.GA22241@omega \
--to=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=phoebe.buckheister@itwm.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.