From: joshc@codeaurora.org (Josh Cartwright)
To: linux-arm-kernel@lists.infradead.org
Subject: static asmlinkage in irqchip (was Re: next build: 78 warnings 0 failures (next/next-20140228))
Date: Mon, 3 Mar 2014 10:12:17 -0600 [thread overview]
Message-ID: <20140303161217.GK7308@joshc.qualcomm.com> (raw)
In-Reply-To: <20140301161258.GN12219@tassilo.jf.intel.com>
On Sat, Mar 01, 2014 at 08:12:58AM -0800, Andi Kleen wrote:
> > These seem to be caused by 128ea04a9885 (lto: Make asmlinkage __visible,
> > 2014-02-08). Before that change asmlinkage was defined to nothing on
> > ARM, but now it's __visible. Should we just drop asmlinkage here?
>
> These functions are just called by the generic C interrupt layer right?
> Yes should just drop asmlinkage. It doesn't make any sense to mark
> functions that only called from C asmlinkage.
On ARM[64], these functions are called from assembly indirectly through
the 'handle_arch_irq' function pointer, so I don't think it makes sense
to drop 'asmlinkage'.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-03-03 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5310415c.2d79420a.3275.ffff92bb@mx.google.com>
2014-03-01 2:23 ` static asmlinkage in irqchip (was Re: next build: 78 warnings 0 failures (next/next-20140228)) Stephen Boyd
2014-03-01 16:12 ` Andi Kleen
2014-03-03 16:12 ` Josh Cartwright [this message]
2014-03-03 16:31 ` Russell King - ARM Linux
2014-03-03 19:06 ` Andi Kleen
2014-03-03 20:21 ` Josh Cartwright
2014-03-05 0:40 ` [PATCH] irqchip: Remove asmlinkage from static functions Stephen Boyd
2014-03-05 0:40 ` Stephen Boyd
2014-03-11 20:43 ` Stephen Boyd
2014-03-11 20:43 ` Stephen Boyd
2014-03-12 12:03 ` [tip:irq/core] " tip-bot for Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303161217.GK7308@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.