From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753890AbaCCRUz (ORCPT ); Mon, 3 Mar 2014 12:20:55 -0500 Received: from one.firstfloor.org ([193.170.194.197]:53268 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbaCCRUx (ORCPT ); Mon, 3 Mar 2014 12:20:53 -0500 Date: Mon, 3 Mar 2014 18:20:50 +0100 From: Andi Kleen To: Masami Hiramatsu Cc: Andi Kleen , linux-kernel@vger.kernel.org, Ingo Molnar , Ananth N Mavinakayanahalli , Sandeepa Prabhu , Frederic Weisbecker , x86@kernel.org, Steven Rostedt , fche@redhat.com, mingo@redhat.com, systemtap@sourceware.org, "H. Peter Anvin" , Thomas Gleixner Subject: Re: Re: [PATCH -tip v7 24/26] kprobes: Enlarge hash table to 4096 entries Message-ID: <20140303172050.GZ22728@two.firstfloor.org> References: <20140227073315.20992.6174.stgit@ltc230.yrl.intra.hitachi.co.jp> <20140227073414.20992.16882.stgit@ltc230.yrl.intra.hitachi.co.jp> <87y50wut4j.fsf@tassilo.jf.intel.com> <530FBA99.3050504@hitachi.com> <53144C01.60106@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53144C01.60106@hitachi.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So, we can see the hash table larger than 2^9 (512 entries, > which consumes 4KB) has no performance improvement. > Would you think 4kB is still big for kprobes? :) 4KB should be fine. Thanks for evaluating. -Andi -- ak@linux.intel.com -- Speaking for myself only.