From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: Update of file offset on write() etc. is non-atomic with I/O Date: Mon, 3 Mar 2014 22:10:14 +0000 Message-ID: <20140303221014.GN18016@ZenIV.linux.org.uk> References: <53022DB1.4070805@gmail.com> <20140303214536.GK18016@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Michael Kerrisk (man-pages)" , lkml , Miklos Szeredi , Theodore T'so , Christoph Hellwig , Chris Mason , Dave Chinner , Linux-Fsdevel , "J. Bruce Fields" , Yongzhi Pan To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Mar 03, 2014 at 02:01:33PM -0800, Linus Torvalds wrote: > On Mon, Mar 3, 2014 at 1:45 PM, Al Viro wrote: > > > > And it looks like you've missed compat counterparts. > > Grr. Yes, I missed them for compat_readv/writev - even though I > grepped for various users, but I grepped for all the *other* cases (ie > vfs_{read|write|llseek}). That means that the locker helper can't be > static to fs/read_write.c. Oh well. It can - compat read/write/read/writev are also there these days. I think that's the only thing you've missed, but I've several more places to trace before I'll be sure.