From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_repair: fix array overrun in do_inode_prefetch
Date: Tue, 4 Mar 2014 10:10:35 +1100 [thread overview]
Message-ID: <20140303231035.GP13647@dastard> (raw)
In-Reply-To: <5314D476.7030503@redhat.com>
On Mon, Mar 03, 2014 at 01:13:58PM -0600, Eric Sandeen wrote:
> Coverity spotted this:
>
> do_inode_prefetch() does a while loop, creating queues:
>
> for (i = 0; i < thread_count; i++) {
> ...
> create_work_queue(&queues[i], mp, 1);
> ...
> }
>
> and then does this to wait for them all to complete:
>
> for (; i >= 0; i--)
> destroy_work_queue(&queues[i]);
>
> But we leave the first for loop with (i == thread_coun)t, and
> the second one will try to index queues[] one past the end.
ugh. My fault. Fix looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-03-03 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 19:13 [PATCH] xfs_repair: fix array overrun in do_inode_prefetch Eric Sandeen
2014-03-03 23:10 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303231035.GP13647@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.