All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Dave Chinner <dchinner@redhat.com>,
	linux-fsdevel@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [xfs] f876e446: +1.2% fileio.requests_per_sec
Date: Tue, 4 Mar 2014 10:17:40 +1100	[thread overview]
Message-ID: <20140303231740.GA6851@dastard> (raw)
In-Reply-To: <20140303142151.GA7935@localhost>

On Mon, Mar 03, 2014 at 10:21:51PM +0800, Fengguang Wu wrote:
> Hi Dave,
> 
> We noticed the below changes on commit f876e44603ad091c840a5fae5b0753bbb421c037
> ("xfs: always do log forces via the workqueue"):
> 
> Basically there are +1.2% increased throughput with +29.5% increased
> context switches.

Yes, the increase in context switches is expected. Every sync IO
causes a log force if it changed inode metadata, and the above
commit, as it describes, moves them to a work queue. Hence there's
more context switches involved in a log force that has to do work.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

      reply	other threads:[~2014-03-03 23:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03 14:21 [xfs] f876e446: +1.2% fileio.requests_per_sec Fengguang Wu
2014-03-03 23:17 ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140303231740.GA6851@dastard \
    --to=david@fromorbit.com \
    --cc=dchinner@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.