From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: Update of file offset on write() etc. is non-atomic with I/O Date: Mon, 3 Mar 2014 23:39:02 +0000 Message-ID: <20140303233902.GP18016@ZenIV.linux.org.uk> References: <20140303210359.26624.qmail@science.horizon.com> <20140303212642.GJ18016@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: George Spelvin , linux-fsdevel , Linux Kernel Mailing List To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Mar 03, 2014 at 03:23:55PM -0800, Linus Torvalds wrote: > This just uses a "flags" field, and we currently only have two bits > that we use: FDPUT_FPUT and FDPUT_POS_UNLOCK. The first patch knows > that "fget_light()" writes 0/1 for that, which is the same as the > FDPUT_FPUT bit. I didn't bother to comment on it or clean it up, since > the second patch just removes that whole fget_light() mess. > > Comments? do_sendfile() is also there and this one is even more unpleasant ;-/ We probably can ignore that one (until POSIX learns of its existence), thouhg...