Re: [PATCH v4] linuxptp: Add recipe for linux ptp

[Denys Dmytriyenko <denys@ti.com>]

On Sun, Mar 02, 2014 at 04:50:46PM -0500, Sam Nelson wrote:
> - linuxptp is an implementation of precision time protocol (PTP)

Much better! Sorry, couple of comments I missed the last time.


> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> 
> ---
> Change from previous patch
> * Removed dependency on kernel
> * Added flags for CLOCKADJTIME & ONESTEPSYNC
> ---
> ---
>  .../recipes-connectivity/linuxptp/linuxptp_1.3.bb  |   23 ++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100755 meta-arago-extras/recipes-connectivity/linuxptp/linuxptp_1.3.bb
> 
> diff --git a/meta-arago-extras/recipes-connectivity/linuxptp/linuxptp_1.3.bb b/meta-arago-extras/recipes-connectivity/linuxptp/linuxptp_1.3.bb
> new file mode 100755
> index 0000000..0a36631
> --- /dev/null
> +++ b/meta-arago-extras/recipes-connectivity/linuxptp/linuxptp_1.3.bb

The latest version is 1.4 and you are adding 1.3 - I only checked 1.4, but 
don't think it changed that much. Do you specifically need 1.3 or 1.4 will 
also work?


> @@ -0,0 +1,23 @@
> +DESCRIPTION = "This software is an implementation of the Precision Time Protocol (PTP) \
> +according to IEEE standard 1588 for Linux"
> +HOMEPAGE = "http://linuxptp.sourceforge.net/"
> +SECTION = "console/network"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +PR = "r0"
> +
> +SRC_URI = "http://iweb.dl.sourceforge.net/project/linuxptp/v${PV}/linuxptp-${PV}.tgz"
> +SRC_URI[md5sum] = "664706a86fe1413391d4536080548501"
> +SRC_URI[sha256sum] = "b1651186689ef06e56add506bd9bb55a700ca56e3f92ba71d08f3ad12fad3085"
> +
> +inherit autotools 

I didn't see any autotools file in the package - no configure script, no 
Makefile.am, no acinclude.m4 etc., etc.


> +EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} ARCH=${TARGET_ARCH} \
> +		EXTRA_CFLAGS=\"-D_GNU_SOURCE -DHAVE_CLOCK_ADJTIME \
> +		-DHAVE_ONESTEP_SYNC\""
> +
> +do_install() {
> +	install -d ${D}${bindir}/
> +	install -c -m 755 ${S}/ptp4l ${D}${bindir}/
> +}

Other than that, looks much cleaner. If you are tired re-iterating it, just 
answer my 2 questions above and I'll make the amends myself when applying your 
patch...

-- 
Denys