From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
shaun@xresource.ca, sachin.kamat@linaro.org,
linux-kernel@vger.kernel.org, ying.xue@windriver.com,
davem@davemloft.net
Subject: Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'
Date: Tue, 4 Mar 2014 12:04:19 +0300 [thread overview]
Message-ID: <20140304090419.GT26722@mwanda> (raw)
In-Reply-To: <1905523.1xUMUtkBrU@daeseok-laptop.cloud.net>
On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
> ci = (ci_t *)(netdev_priv(hi->ndev));
> for (j = 0; j < ci->max_port; j++)
> for (k = 0; k < MUSYCC_NCHANS; k++)
> - if ((ndev = ci->port[j].chan[k]->user))
> + ndev = ci->port[j].chan[k]->user;
> + if (ndev)
> {
> do_deluser(ndev, 0);
> }
This patch introduces a bug here because the inner for loop now has two
statement but no curly braces.
regards,
dan carpenter
next prev parent reply other threads:[~2014-03-04 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 2:09 [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition' Daeseok Youn
2014-03-04 9:04 ` Dan Carpenter [this message]
2014-03-04 10:18 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304090419.GT26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=shaun@xresource.ca \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.