All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests: fix error msg in aio-dio-subblock-eof-read.c
Date: Tue, 4 Mar 2014 10:05:11 -0500	[thread overview]
Message-ID: <20140304150511.GB51235@bfoster.bfoster> (raw)
In-Reply-To: <5315681C.5070704@sandeen.net>

On Mon, Mar 03, 2014 at 11:43:56PM -0600, Eric Sandeen wrote:
> io_getevents returns the number of events; printing its
> return as "bytes read" is ... wrong.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> V2: print as signed so we can easily see errors returned
> 

Reviewed-by: Brian Foster <bfoster@redhat.com>

> diff --git a/src/aio-dio-regress/aio-dio-subblock-eof-read.c b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> index a48841d..8f74cec 100644
> --- a/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> +++ b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> @@ -105,8 +107,8 @@ main(int argc, char **argv)
>  	 *  are broken, we may very well see a result of 4k.
>  	 */
>  	if (ie.res != FILE_SIZE)
> -		fail("AIO read of last block in file returned %d bytes, "
> -		     "expected %d\n", ret, FILE_SIZE);
> +		fail("AIO read of last block in file returned %ld bytes, "
> +		     "expected %d\n", ie.res, FILE_SIZE);
>  
>  	printf("AIO read of last block in file succeeded.\n");
>  	return 0;
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2014-03-04 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04  5:24 [PATCH] xfstests: fix error msg in aio-dio-subblock-eof-read.c Eric Sandeen
2014-03-04  5:43 ` [PATCH V2] " Eric Sandeen
2014-03-04 15:05   ` Brian Foster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140304150511.GB51235@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.