From: simon.kagstrom@netinsight.net (Simon Kågström)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ixp4xx_eth: Setup coherent_dma_mask
Date: Wed, 5 Mar 2014 08:55:49 +0100 [thread overview]
Message-ID: <20140305085549.3eb22236@marrow.netinsight.se> (raw)
In-Reply-To: <20140305085311.07b3922a@marrow.netinsight.se>
This driver has been broken since commit 1a4901177574083c35fafc24c4d151c2a7c7647c
ixp4xx_eth: avoid calling dma_pool_create() with NULL dev
in 3.7 and would fail with
[ 33.055473] net eth1: coherent DMA mask is unset
[ 33.055523] net eth1: coherent allocation too big (requested 0x1000 mask 0x0)
Fix by setting up the DMA mask to the entire 32-bit range.
Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
---
drivers/net/ethernet/xscale/ixp4xx_eth.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
index 25283f1..e540e51 100644
--- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
+++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
@@ -1426,6 +1426,10 @@ static int eth_init_one(struct platform_device *pdev)
port->netdev = dev;
port->id = pdev->id;
+ err = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(32));
+ if (err < 0)
+ goto err_free;
+
switch (port->id) {
case IXP4XX_ETH_NPEA:
port->regs = (struct eth_regs __iomem *)IXP4XX_EthA_BASE_VIRT;
--
1.7.9.6
next prev parent reply other threads:[~2014-03-05 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 7:53 [PATCH 0/2]: ixp4xx: Fix 3.7 regression for IXP4xx ethernet driver Simon Kågström
2014-03-05 7:55 ` [PATCH 1/2] ARM: ixp4xx: Make dma_set_coherent_mask common, correct implementation Simon Kågström
2014-03-05 7:55 ` Simon Kågström [this message]
2014-03-05 9:21 ` [PATCH 2/2] ixp4xx_eth: Setup coherent_dma_mask Krzysztof Hałasa
2014-03-05 9:43 ` Russell King - ARM Linux
2014-03-05 9:55 ` Krzysztof Hałasa
2014-03-05 10:07 ` Simon Kågström
2014-03-05 10:12 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305085549.3eb22236@marrow.netinsight.se \
--to=simon.kagstrom@netinsight.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.