From: Dan Carpenter <dan.carpenter@oracle.com>
To: tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: Re: ALSA: emu10k1: Use standard printk helpers
Date: Wed, 5 Mar 2014 14:05:09 +0300 [thread overview]
Message-ID: <20140305110344.GA16926@elgon.mountain> (raw)
Hello Takashi Iwai,
The patch 6f002b02166c: "ALSA: emu10k1: Use standard printk helpers"
from Feb 25, 2014, leads to the following static checker warning:
sound/pci/emu10k1/io.c:75 snd_emu10k1_ptr_write()
error: we previously assumed 'emu' could be null (see line 74)
sound/pci/emu10k1/io.c
68 void snd_emu10k1_ptr_write(struct snd_emu10k1 *emu, unsigned int reg, unsigned int chn, unsigned int data)
69 {
70 unsigned int regptr;
71 unsigned long flags;
72 unsigned int mask;
73
74 if (!emu) {
^^^^
75 dev_err(emu->card->dev, "ptr_write: emu is null!\n");
^^^^^^^^^^^^^^
Dereference.
76 dump_stack();
77 return;
78 }
regards,
dan carpenter
next reply other threads:[~2014-03-05 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 11:05 Dan Carpenter [this message]
2014-03-05 11:11 ` ALSA: emu10k1: Use standard printk helpers Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305110344.GA16926@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.