All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: linux-wireless@vger.kernel.org
Cc: Pedro Francisco <pedrogfrancisco@gmail.com>
Subject: [RFC/RFT 10/9] iwlegacy: fix uninitialized var
Date: Wed, 5 Mar 2014 13:23:59 +0100	[thread overview]
Message-ID: <20140305122358.GA3022@redhat.com> (raw)
In-Reply-To: <1394021614-11514-1-git-send-email-sgruszka@redhat.com>


diff --git a/drivers/net/wireless/iwlegacy/common.c b/drivers/net/wireless/iwlegacy/common.c
index 9f6c492..2cc8a54 100644
--- a/drivers/net/wireless/iwlegacy/common.c
+++ b/drivers/net/wireless/iwlegacy/common.c
@@ -1272,8 +1272,10 @@ il_send_scan_abort(struct il_priv *il)
 	    !test_bit(S_GEO_CONFIGURED, &il->status) ||
 	    !test_bit(S_SCAN_HW, &il->status) ||
 	    test_bit(S_FW_ERROR, &il->status) ||
-	    test_bit(S_EXIT_PENDING, &il->status))
+	    test_bit(S_EXIT_PENDING, &il->status)) {
+		ret = -EIO;
 		goto out;
+	}
 
 	ret = il_send_cmd_sync(il, &cmd);
 	if (ret)

  parent reply	other threads:[~2014-03-05 12:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 12:13 [RFC/RFT 0/9] iwlegacy rework rx allocation Stanislaw Gruszka
2014-03-05 12:13 ` [RFC/RFT 1/9] iwlegacy: add pkt pointer to command Stanislaw Gruszka
2014-03-05 12:13 ` [RFC/RFT 2/9] iwlegacy: use CMD_COPY_PKT on il3945_get_measurement Stanislaw Gruszka
2014-03-05 12:13 ` [RFC/RFT 3/9] iwlegacy: use CMD_COPY_PKT on il_send_scan_abort Stanislaw Gruszka
2014-03-05 12:13 ` [RFC/RFT 4/9] iwlegacy: use CMD_COPY_PKT on il_send_add_sta Stanislaw Gruszka
2014-03-05 12:13 ` [RFC/RFT 5/9] iwlegacy: use CMD_COPY_PKT on il_send_remove_station Stanislaw Gruszka
2014-03-05 12:13 ` [RFC/RFT 6/9] iwlegacy: use CMD_COPY_PKT on il3945_send_rxon_assoc Stanislaw Gruszka
2014-03-05 12:13 ` [RFC/RFT 7/9] iwlegacy: get rit of CMD_WANT_SKB Stanislaw Gruszka
2014-03-05 12:13 ` [RFC/RFT 8/9] iwlegacy: treat RX notify specially Stanislaw Gruszka
2014-03-05 12:13 ` [RFC/RFT 9/9] iwlegacy: rework rx buffers allocation Stanislaw Gruszka
2014-03-05 12:23 ` Stanislaw Gruszka [this message]
2014-03-20 10:16 ` [RFC/RFT 0/9] iwlegacy rework rx allocation Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305122358.GA3022@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pedrogfrancisco@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.