All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <christophe.gouault@6wind.com>
Subject: Re: [PATCH RFC 01/12] xfrm: Introduce xfrm_input_afinfo to access the the callbacks properly
Date: Wed, 5 Mar 2014 13:24:40 +0100	[thread overview]
Message-ID: <20140305122440.GS32371@secunet.com> (raw)
In-Reply-To: <20140302.200923.1500412807288633496.davem@davemloft.net>

On Sun, Mar 02, 2014 at 08:09:23PM -0500, David Miller wrote:
> From: Steffen Klassert <steffen.klassert@secunet.com>
> Date: Fri, 28 Feb 2014 11:31:11 +0100
> 
> > +	int err = 0;
> > +	if (unlikely(afinfo == NULL))
> > +		return -EINVAL;
> 
> A newline between local variable declarations and code, please.
> 

This was a copy and paste from xfrm_state_register_afinfo :)

I've incorporated your feedback into the next version of
this patchset. Thanks for the review!

  reply	other threads:[~2014-03-05 12:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 10:31 [PATCH RFC 0/12] vti6: prepare namespace and interfamily support Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 01/12] xfrm: Introduce xfrm_input_afinfo to access the the callbacks properly Steffen Klassert
2014-03-03  1:09   ` David Miller
2014-03-05 12:24     ` Steffen Klassert [this message]
2014-02-28 10:31 ` [PATCH RFC 02/12] xfrm6: Add IPsec protocol multiplexer Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 03/12] esp6: Use the IPsec protocol multiplexer API Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 04/12] ah6: " Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 05/12] ipcomp6: " Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 06/12] vti6: Remove dst_entry caching Steffen Klassert
2014-03-03 10:58   ` Nicolas Dichtel
2014-02-28 10:31 ` [PATCH RFC 07/12] vti6: Remove caching of flow informations Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 08/12] vti6: Update the ipv6 side to use it's own receive hook Steffen Klassert
2014-03-03  1:12   ` David Miller
2014-02-28 10:31 ` [PATCH RFC 09/12] xfrm6: Remove xfrm_tunnel_notifier Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 10/12] vti6: Support inter address family tunneling Steffen Klassert
2014-03-03  1:13   ` David Miller
2014-02-28 10:31 ` [PATCH RFC 11/12] vti6: Check the tunnel endpoints of the xfrm state and the vti interface Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 12/12] vti6: Enable namespace changing Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305122440.GS32371@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=christophe.gouault@6wind.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.