All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: David Miller <davem@davemloft.net>
Cc: edumazet@google.com, gustavold@linux.vnet.ibm.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net: unix socket code abuses csum_partial
Date: Wed, 5 Mar 2014 14:28:09 +1100	[thread overview]
Message-ID: <20140305142809.64a71498@kryten> (raw)
In-Reply-To: <20140304.134141.1732220919806520941.davem@davemloft.net>


Hi Dave,

> Alternatively you could just make unix_hash_fold() use csum_fold(),
> right?
> 
> static inline unsigned int unix_hash_fold(__wsum n)
> {
> 	unsigned int hash = (__force unsigned int) csum_fold(n);
> 
> 	hash ^= hash>>8;
> 	return hash&(UNIX_HASH_SIZE-1);
> }

Thanks, sounds good. Updated patch on the way.

Anton

  parent reply	other threads:[~2014-03-05  3:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 10:01 [PATCH] net: unix socket code abuses csum_partial Anton Blanchard
2014-03-04 18:41 ` David Miller
2014-03-04 18:50   ` Eric Dumazet
2014-03-04 21:23     ` David Miller
2014-03-04 21:55       ` Eric Dumazet
2014-03-05  3:28   ` Anton Blanchard [this message]
2014-03-05  3:29 ` Anton Blanchard
2014-03-06 21:19   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305142809.64a71498@kryten \
    --to=anton@samba.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gustavold@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.