All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help
Date: Wed, 5 Mar 2014 09:06:32 -0800	[thread overview]
Message-ID: <20140305170632.GC11667@infradead.org> (raw)
In-Reply-To: <1393981893-2497-2-git-send-email-david@fromorbit.com>

This looks correct, but why don't we simply have a special cased
function looking or any delalloc page for xfs_aops_discard_page instead
of having one that is fairly over-general?

Reviewed-by: Christoph Hellwig <hch@lst.de>

if you want to go down this route anyway.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-03-05 17:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05  1:11 [PATCH 0/2] xfs: more bug fixes Dave Chinner
2014-03-05  1:11 ` [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help Dave Chinner
2014-03-05 17:06   ` Christoph Hellwig [this message]
2014-03-05 22:08   ` Brian Foster
2014-03-05 23:18     ` Dave Chinner
2014-03-05  1:11 ` [PATCH 2/2] xfs: inode log reservations are still too small Dave Chinner
2014-03-05  3:33   ` Eric Sandeen
2014-03-05 16:06   ` Brian Foster
2014-03-05 17:14   ` Christoph Hellwig
2014-03-05 21:40     ` Dave Chinner
2014-03-05 22:34       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305170632.GC11667@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.