All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Andreas Fenkart <afenkart@gmail.com>
Cc: Chris Ball <chris@printf.net>,
	Grant Likely <grant.likely@secretlab.ca>,
	Felipe Balbi <balbi@ti.com>, Balaji T K <balajitk@ti.com>,
	zonque@gmail.com, galak@codeaurora.org,
	linux-doc@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH v8 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.
Date: Wed, 5 Mar 2014 10:55:45 -0800	[thread overview]
Message-ID: <20140305185544.GI4983@atomide.com> (raw)
In-Reply-To: <1394008070-30138-1-git-send-email-afenkart@gmail.com>

* Andreas Fenkart <afenkart@gmail.com> [140305 00:39]:
> Hi Tony,
> 
> I had an infinite loop in hsmmc_disable_wake_irq. Since the SDIO
> irq is level triggered, I have to disable the IRQ in the handler
> otherwise it is called infinitely. 
> 
> Did some other minor changes see below.
> 
> v8
> - rebased on top of Tony Lindgren<tony@atomide.com> changes
>   - improved changelog describing the earlier work
>   - improved wakeup irq setup
>   - works on am3730 es platform now
> - my changes on top:
>   - compile tested with #undef CONFIG_OF
>   - disable wake_irq in handler to prevent infinite loop  
>   - fixed typo and added comment about wake-irq

Great, tested here and things work for me for waking omap3
from off-idle based on the SDIO interrupt.

Maybe leave out the trailing period from the Subject line
for the last patch? If you look at git log --pretty=oneline
the trailing period is rarely used :)

Balaji, care to queue or ack these for Chris? Looks like
Chris has a wrong email address (corrected in this mail),
so maybe one more repost of the series is needed.

Regards,

Tony

      parent reply	other threads:[~2014-03-05 18:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05  8:27 [PATCH v8 0/3] mmc: omap_hsmmc: Enable SDIO IRQ Andreas Fenkart
2014-03-05  8:27 ` [PATCH v8 1/3] mmc: omap_hsmmc: Enable SDIO interrupt Andreas Fenkart
2014-03-05  8:27 ` [PATCH v8 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x Andreas Fenkart
2014-03-05  8:27 ` [PATCH v8 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux Andreas Fenkart
2014-03-05 18:55 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305185544.GI4983@atomide.com \
    --to=tony@atomide.com \
    --cc=afenkart@gmail.com \
    --cc=balajitk@ti.com \
    --cc=balbi@ti.com \
    --cc=chris@printf.net \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.