From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Simon Horman <horms@verge.net.au>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Jiri Slaby <jslaby@suse.cz>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-serial@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Subject: Re: [PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path
Date: Thu, 06 Mar 2014 04:34:25 +0000 [thread overview]
Message-ID: <20140306043425.GA24704@kroah.com> (raw)
In-Reply-To: <20140306041912.GB29693@verge.net.au>
On Thu, Mar 06, 2014 at 01:19:13PM +0900, Simon Horman wrote:
> On Fri, Feb 28, 2014 at 02:21:33PM +0100, Geert Uytterhoeven wrote:
> > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> >
> > If cpufreq_register_notifier() fails, we have to remove the port added by
> > sci_probe_single(), which is not done by sci_cleanup_single().
> >
> > Else the serial port stays active from the point of view of the serial
> > subsystem, and it may crash when userspace getty is started, or when the
> > loadable driver module is unloaded.
> >
> > This was introduced by commit 6dae14216c85eea13db7b12c469475c5d30e5499
> > ("serial: sh-sci: Fix probe error paths").
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> This looks reasonable to me.
>
> Greg, could you take this one?
Will do, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Simon Horman <horms@verge.net.au>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Jiri Slaby <jslaby@suse.cz>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-serial@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Subject: Re: [PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path
Date: Wed, 5 Mar 2014 20:34:25 -0800 [thread overview]
Message-ID: <20140306043425.GA24704@kroah.com> (raw)
In-Reply-To: <20140306041912.GB29693@verge.net.au>
On Thu, Mar 06, 2014 at 01:19:13PM +0900, Simon Horman wrote:
> On Fri, Feb 28, 2014 at 02:21:33PM +0100, Geert Uytterhoeven wrote:
> > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> >
> > If cpufreq_register_notifier() fails, we have to remove the port added by
> > sci_probe_single(), which is not done by sci_cleanup_single().
> >
> > Else the serial port stays active from the point of view of the serial
> > subsystem, and it may crash when userspace getty is started, or when the
> > loadable driver module is unloaded.
> >
> > This was introduced by commit 6dae14216c85eea13db7b12c469475c5d30e5499
> > ("serial: sh-sci: Fix probe error paths").
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> This looks reasonable to me.
>
> Greg, could you take this one?
Will do, thanks.
next prev parent reply other threads:[~2014-03-06 4:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 13:21 [PATCH 1/2] serial_core: Unregister console in uart_remove_one_port() Geert Uytterhoeven
2014-02-28 13:21 ` Geert Uytterhoeven
2014-02-28 13:21 ` [PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path Geert Uytterhoeven
2014-02-28 13:21 ` Geert Uytterhoeven
2014-03-06 4:19 ` Simon Horman
2014-03-06 4:19 ` Simon Horman
2014-03-06 4:34 ` Greg Kroah-Hartman [this message]
2014-03-06 4:34 ` Greg Kroah-Hartman
2014-03-11 1:06 ` [PATCH 1/2] serial_core: Unregister console in uart_remove_one_port() Peter Hurley
2014-03-11 1:06 ` Peter Hurley
2014-03-11 3:43 ` Peter Hurley
2014-03-11 3:43 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306043425.GA24704@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=geert+renesas@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jslaby@suse.cz \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.