From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] credit: Change default timeslice to 5ms
Date: Thu, 6 Mar 2014 11:39:29 +0100
Message-ID: <20140306103929.GD11475@deinos.phlegethon.org>
References: <1394036976-484-1-git-send-email-george.dunlap@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1394036976-484-1-git-send-email-george.dunlap@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Marcus Granado <Marcus.Granado@eu.citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

At 16:29 +0000 on 05 Mar (1394033376), George Dunlap wrote:
> The 30ms timeslice was chosen nearly a decade ago now, with cpu
> "burning" workloads in mind.  In the mean time, processors have gotten
> faster and VMEXITs have gotten faster.  A timeslice of 30ms has a
> major cost when running latency-sensitive workloads like network or
> audio streaming: getting caught behind just one or two other VMs can
> introduce a processing delay of up to 60ms, and the "round-robin"
> nature of the credit scheduler means this delay may be introduced
> every time the VM yields for periods of time.
> 
> The XenServer performance team at Citrix have done extensive testing
> with various timeslices, including 30ms, 10ms, 5ms, and 2ms.  None of
> the workloads exhibited any performance degradation with a 5ms
> timeslice.
> 
> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
> ---
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>

Acked-by: Tim Deegan <tim@xen.org>

> CC: Keir Fraser <keir@xen.org>
> CC: Dario Faggioli <dario.faggioli@citrix.com>
> CC: Marcus Granado <Marcus.Granado@eu.citrix.com>
> ---
>  xen/common/sched_credit.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
> index db5512e..61553d9 100644
> --- a/xen/common/sched_credit.c
> +++ b/xen/common/sched_credit.c
> @@ -29,9 +29,9 @@
>   * Basic constants
>   */
>  #define CSCHED_DEFAULT_WEIGHT       256
> -#define CSCHED_TICKS_PER_TSLICE     3
> -/* Default timeslice: 30ms */
> -#define CSCHED_DEFAULT_TSLICE_MS    30
> +#define CSCHED_TICKS_PER_TSLICE     1
> +/* Default timeslice: 5ms */
> +#define CSCHED_DEFAULT_TSLICE_MS    5
>  #define CSCHED_CREDITS_PER_MSEC     10
>  
>  
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel