From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45115)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WLY1n-0006oe-PE
	for qemu-devel@nongnu.org; Thu, 06 Mar 2014 08:08:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WLY1h-0002ge-Qa
	for qemu-devel@nongnu.org; Thu, 06 Mar 2014 08:07:59 -0500
Received: from lnantes-156-75-100-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:55835 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WLY1h-0002ga-KM
	for qemu-devel@nongnu.org; Thu, 06 Mar 2014 08:07:53 -0500
Date: Thu, 6 Mar 2014 14:07:53 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140306130752.GG3132@irqsave.net>
References: <1394055700-5988-1-git-send-email-mreitz@redhat.com>
	<20140306125755.GE2663@dhcp-200-207.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20140306125755.GE2663@dhcp-200-207.str.redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from
 filenames
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

The Thursday 06 Mar 2014 =E0 13:57:55 (+0100), Kevin Wolf wrote :
> Am 05.03.2014 um 22:41 hat Max Reitz geschrieben:
> > The "file" protocol drivers (block/raw-posix and block/raw-win32) may=
 be
> > explicitly selected by prepending a "file:" prefix to a filename (as
> > with all other block protocols). However, currently, they do not stri=
p
> > this prefix as they should.
> >=20
> > This series fixes this issue.
>=20
> Thanks, applied to the block branch.
Heh my review was too late :)

>=20
> This is just for consistency and there is no real use case for this,
> right? If so, it would be even more consistent to do the same for the
> host_* drivers provided by block/raw-{posix,win32}.c
>=20
> I talked about this multiple times in discussions about handling colons
> in filenames, so that prefixing file: would make it unambigious that th=
e
> colon is part of the file name and not a protocol name, but these days =
I
> think we already have enough other ways to express this (the easiest
> being ./test:foo, because protocols can't contain slashes)
>=20
> Kevin
>=20