From: Theodore Ts'o <tytso@mit.edu>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Eryu Guan <guaneryu@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] mke2fs: disable resize_inode feature if 64bit feature is enabled
Date: Thu, 6 Mar 2014 10:18:11 -0500 [thread overview]
Message-ID: <20140306151811.GB22136@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1403061458340.2249@localhost.localdomain>
On Thu, Mar 06, 2014 at 03:03:30PM +0100, Lukáš Czerner wrote:
>
> I am sorry, but am I missing something ? This patch seems to do
> exactly that.
>
> if ((fs_blocks_count > MAX_32_NUM) &&
> + (fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT))
> + fs_param.s_feature_compat &= ~EXT2_FEATURE_COMPAT_RESIZE_INODE;
>
> The answer from you on that patch is commenting on a guestion from
> Zheng Liu who is asking whether we could skip the MAX_32_NUM check.
You're right, I misread the patch and the e-mail thread.
Thanks, I've applied the patch.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-03-06 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 9:05 [PATCH] mke2fs: disable resize_inode feature if 64bit feature is enabled Eryu Guan
2013-07-05 1:21 ` Zheng Liu
2013-07-07 15:41 ` Theodore Ts'o
2014-03-03 15:40 ` Lukáš Czerner
2014-03-04 15:19 ` Theodore Ts'o
2014-03-06 14:03 ` Lukáš Czerner
2014-03-06 15:18 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306151811.GB22136@thunk.org \
--to=tytso@mit.edu \
--cc=guaneryu@gmail.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.