Re: [PATCH 2/2] ext4: fix bug in ext4_mb_normalize_request()

[Theodore Ts'o <tytso@mit.edu>]

On Thu, Mar 06, 2014 at 06:54:05PM +0100, Lukáš Czerner wrote:
> 
> All that said, I was getting to rewrite this mess a long time ago,
> it's just a reminder that it's something that needs to be done.
> Especially since the bigger requests are getting split unnecessarily
> which hurts especially in fallocate case.

Hey Lukas,

If you are going to try to do some clean up work in mballoc, that
would be really really great!  (Although hopefully you can still work
on writing down some thoughts about the data block checksum feature
before the ext4 developer's workshop.  :-)

We should try to get input from Andreas about what some of the more
interesting hueristics in mballoc were trying to accomplish, since
there's a lot going on that's not obvious, and one of the reasons why
I've always been worried about trying to do cleanups was because
something that looks ugly might be papering over some other dark
corner of mballoc.c ---- and so I was fairly certain that one we
started opening up mballoc.c, we'd have to do a lot of work on it, and
a lot of performance measurements to make sure we didn't accidentally
introduce some performance regression.

Thanks for being willing to look at this!

Cheers,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html