All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Maxin B. John" <maxin.john@gmail.com>,
	devel@driverdev.osuosl.org, andreas.dilger@intel.com,
	bergwolf@gmail.com, alexey.zhuravlev@intel.com,
	linux-kernel@vger.kernel.org, dulshani.gunawardhana89@gmail.com,
	josh@joshtriplett.org, jinshan.xiong@intel.com,
	"Maxin B. John" <maxin.john@enea.com>
Subject: Re: [PATCH 1/2] lustre/mdc_lib: fix possible null pointer dereference
Date: Thu, 6 Mar 2014 11:51:42 -0800	[thread overview]
Message-ID: <20140306195142.GA3403@kroah.com> (raw)
In-Reply-To: <20140305185048.GC26722@mwanda>

On Wed, Mar 05, 2014 at 09:53:06PM +0300, Dan Carpenter wrote:
> On Wed, Mar 05, 2014 at 02:04:35PM +0100, Maxin B. John wrote:
> > From: "Maxin B. John" <maxin.john@enea.com>
> > 
> > cppcheck reported possible null pointer dereference in mdc_lib.c
> > 
> > [lustre/lustre/mdc/mdc_lib.c:233]: (error) Possible null pointer dereference
> > : op_data - otherwise it is redundant to check if op_data is null at line 226
> > 
> 
> There is only one caller and "op_data" is not NULL.

I agree, John, please fix your tools.  Or check the result and fix the
code so that there isn't false-positives (by not checking for NULL at
all here...)

thanks,

greg k-h

  reply	other threads:[~2014-03-06 19:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 13:04 [PATCH 1/2] lustre/mdc_lib: fix possible null pointer dereference Maxin B. John
2014-03-05 13:04 ` [PATCH 2/2] lustre/lov_obd: " Maxin B. John
2014-03-06 19:53   ` Greg KH
2014-03-05 18:53 ` [PATCH 1/2] lustre/mdc_lib: " Dan Carpenter
2014-03-06 19:51   ` Greg KH [this message]
2014-03-06 21:41     ` Maxin B. John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140306195142.GA3403@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexey.zhuravlev@intel.com \
    --cc=andreas.dilger@intel.com \
    --cc=bergwolf@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dulshani.gunawardhana89@gmail.com \
    --cc=jinshan.xiong@intel.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxin.john@enea.com \
    --cc=maxin.john@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.