From: Jean-Francois Moine <moinejf@free.fr>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i2c: tda998x: potentially faster polling for edid
Date: Thu, 6 Mar 2014 20:32:30 +0100 [thread overview]
Message-ID: <20140306203230.31bfe5e4@armhf> (raw)
In-Reply-To: <E1WKXBG-0003gB-GK@rmk-PC.arm.linux.org.uk>
On Mon, 03 Mar 2014 18:01:34 +0000
Russell King <rmk+kernel@arm.linux.org.uk> wrote:
> One of Jean-Francois patches changed the EDID polling to once every
> 10ms for 10 interations, whereas the original code did 1ms for 100
> interations. This appears to cause boot-time detection to take
> slightly - but noticably - longer. Revert this change.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Jean,
>
> I'm not sure why you made the change along with adding IRQ support in
> "drm/i2c: tda998x: use irq for connection status and EDID read" - you
> didn't include any commentry as to why you made this change. However,
> we shouldn't write code assuming HZ=100 - where this kind of thing
> matters, we should come up with better solutions (eg, using jiffy-based
> timeouts if we want to timeout after a set period of time.)
>
> I'm not sure whether one or other really is faster, it's just a
> perception I have. Anyway, let's just revert back to the original
> code for the non-IRQ case, and maybe improve it later.
Russell,
Sorry for the problem. I was thinking that, if you want to read quickly
the EDID , you may use the IRQ, but, if you don't use the IRQ, maybe you
have real-time constraints, and, so, reducing the wait loop could help
you.
Acked-by: Jean-Francois Moine <moinejf@free.fr>
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-03-06 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 18:01 [PATCH] drm/i2c: tda998x: potentially faster polling for edid Russell King
2014-03-06 19:32 ` Jean-Francois Moine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306203230.31bfe5e4@armhf \
--to=moinejf@free.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.