From: Arno Wagner <arno@wagner.name>
To: dm-crypt@saout.de
Subject: Re: [dm-crypt] goto patch for cryptsetup?
Date: Fri, 7 Mar 2014 00:27:21 +0100 [thread overview]
Message-ID: <20140306232721.GA21506@tansi.org> (raw)
In-Reply-To: <5318DCEF.5020004@tu-ilmenau.de>
I don't think that is a good idea. The "goto fail" was a
problem due to either a high level of incompetence, or
due to intent disguised as a high level of incompetence.
I think well-placed gotos are actually clearer and less
risky than the structured programming equivalents.
What happened with iOS would have been blatantly
obvious with even minimal code review or a single
test-case for the skipped functionality. That these
were not done is pretty bad.
Of course, the final decision is Milan's. But I think
what would be far better is that you review all these
goto's as to whether any of them is a problem. That is
still less useful than a real review, but at least it
may alleviate the concerns of the "syntactic matching
people" that see the "goto" as a problem (or "sha-1",
or the like) instead of the specific use.
Arno
On Thu, Mar 06, 2014 at 21:39:11 CET, Lars Winterfeld wrote:
> Hi,
>
> in light of the latest "goto fail"s out there, would you reject a patch
> replacing all 328 gotos with their semantic equivalents from structured
> C programming?
>
> Best wishes,
> Lars
> _______________________________________________
> dm-crypt mailing list
> dm-crypt@saout.de
> http://www.saout.de/mailman/listinfo/dm-crypt
--
Arno Wagner, Dr. sc. techn., Dipl. Inform., Email: arno@wagner.name
GnuPG: ID: CB5D9718 FP: 12D6 C03B 1B30 33BB 13CF B774 E35C 5FA1 CB5D 9718
----
A good decision is based on knowledge and not on numbers. - Plato
next prev parent reply other threads:[~2014-03-06 23:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 20:39 [dm-crypt] goto patch for cryptsetup? Lars Winterfeld
2014-03-06 23:27 ` Arno Wagner [this message]
2014-03-07 5:23 ` Milan Broz
2014-03-07 10:52 ` Lars Winterfeld
2014-03-07 12:11 ` Arno Wagner
2014-03-07 12:16 ` .. ink ..
2014-03-07 16:11 ` Milan Broz
2014-03-08 16:20 ` Arno Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306232721.GA21506@tansi.org \
--to=arno@wagner.name \
--cc=dm-crypt@saout.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.