From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.126.187]:57726 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967AbaCGA01 (ORCPT ); Thu, 6 Mar 2014 19:26:27 -0500 From: Arnd Bergmann To: Lucas Stach Subject: Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible Date: Fri, 7 Mar 2014 01:25:28 +0100 Cc: Stephen Warren , linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, Jingoo Han , Bjorn Helgaas , Simon Horman , Shawn Guo , Ben Dooks , Kukjin Kim , Thierry Reding , kernel@pengutronix.de References: <1394025951-32438-1-git-send-email-l.stach@pengutronix.de> <5318B232.2020507@wwwdotorg.org> <1394127555.4582.1.camel@weser.hi.pengutronix.de> In-Reply-To: <1394127555.4582.1.camel@weser.hi.pengutronix.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Message-Id: <201403070125.28582.arnd@arndb.de> Sender: linux-pci-owner@vger.kernel.org List-ID: On Thursday 06 March 2014, Lucas Stach wrote: > Am Donnerstag, den 06.03.2014, 10:36 -0700 schrieb Stephen Warren: > > On 03/05/2014 06:25 AM, Lucas Stach wrote: > > > This is the recommended method of doing the IRQ > > > mapping. For old devicetrees we fall back to the > > > previous practice. > > > > Tested-by: Stephen Warren > > > > I tested both with and without patch 1/6, and the PCIe-based NIC on > > Beaver worked fine either way. Without patch 1/6, I do see: > > > > pci 0000:00:01.0: of_irq_parse_pci() failed with rc=-22 > > > > ... but that seems reasonable given that the DT that of_irq_parse_pci() > > parses is missing, and did correctly trigger the fallback path, so > > everything still worked. > > Yes, this should be normal. It spits this error for old DTs, but keeps > doing the right thing. I'm not sure if we should downgrade this to info > or dbg. No, I think printing an error like this is appropriate: it is an incentive to update the dts files, but doesn't look too urgent as long as everything still works. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible Date: Fri, 7 Mar 2014 01:25:28 +0100 Message-ID: <201403070125.28582.arnd@arndb.de> References: <1394025951-32438-1-git-send-email-l.stach@pengutronix.de> <5318B232.2020507@wwwdotorg.org> <1394127555.4582.1.camel@weser.hi.pengutronix.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394127555.4582.1.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lucas Stach Cc: Stephen Warren , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jingoo Han , Bjorn Helgaas , Simon Horman , Shawn Guo , Ben Dooks , Kukjin Kim , Thierry Reding , kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org On Thursday 06 March 2014, Lucas Stach wrote: > Am Donnerstag, den 06.03.2014, 10:36 -0700 schrieb Stephen Warren: > > On 03/05/2014 06:25 AM, Lucas Stach wrote: > > > This is the recommended method of doing the IRQ > > > mapping. For old devicetrees we fall back to the > > > previous practice. > > > > Tested-by: Stephen Warren > > > > I tested both with and without patch 1/6, and the PCIe-based NIC on > > Beaver worked fine either way. Without patch 1/6, I do see: > > > > pci 0000:00:01.0: of_irq_parse_pci() failed with rc=-22 > > > > ... but that seems reasonable given that the DT that of_irq_parse_pci() > > parses is missing, and did correctly trigger the fallback path, so > > everything still worked. > > Yes, this should be normal. It spits this error for old DTs, but keeps > doing the right thing. I'm not sure if we should downgrade this to info > or dbg. No, I think printing an error like this is appropriate: it is an incentive to update the dts files, but doesn't look too urgent as long as everything still works. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Fri, 07 Mar 2014 00:25:28 +0000 Subject: Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible Message-Id: <201403070125.28582.arnd@arndb.de> List-Id: References: <1394025951-32438-1-git-send-email-l.stach@pengutronix.de> <5318B232.2020507@wwwdotorg.org> <1394127555.4582.1.camel@weser.hi.pengutronix.de> In-Reply-To: <1394127555.4582.1.camel@weser.hi.pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thursday 06 March 2014, Lucas Stach wrote: > Am Donnerstag, den 06.03.2014, 10:36 -0700 schrieb Stephen Warren: > > On 03/05/2014 06:25 AM, Lucas Stach wrote: > > > This is the recommended method of doing the IRQ > > > mapping. For old devicetrees we fall back to the > > > previous practice. > > > > Tested-by: Stephen Warren > > > > I tested both with and without patch 1/6, and the PCIe-based NIC on > > Beaver worked fine either way. Without patch 1/6, I do see: > > > > pci 0000:00:01.0: of_irq_parse_pci() failed with rc=-22 > > > > ... but that seems reasonable given that the DT that of_irq_parse_pci() > > parses is missing, and did correctly trigger the fallback path, so > > everything still worked. > > Yes, this should be normal. It spits this error for old DTs, but keeps > doing the right thing. I'm not sure if we should downgrade this to info > or dbg. No, I think printing an error like this is appropriate: it is an incentive to update the dts files, but doesn't look too urgent as long as everything still works. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 7 Mar 2014 01:25:28 +0100 Subject: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible In-Reply-To: <1394127555.4582.1.camel@weser.hi.pengutronix.de> References: <1394025951-32438-1-git-send-email-l.stach@pengutronix.de> <5318B232.2020507@wwwdotorg.org> <1394127555.4582.1.camel@weser.hi.pengutronix.de> Message-ID: <201403070125.28582.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 06 March 2014, Lucas Stach wrote: > Am Donnerstag, den 06.03.2014, 10:36 -0700 schrieb Stephen Warren: > > On 03/05/2014 06:25 AM, Lucas Stach wrote: > > > This is the recommended method of doing the IRQ > > > mapping. For old devicetrees we fall back to the > > > previous practice. > > > > Tested-by: Stephen Warren > > > > I tested both with and without patch 1/6, and the PCIe-based NIC on > > Beaver worked fine either way. Without patch 1/6, I do see: > > > > pci 0000:00:01.0: of_irq_parse_pci() failed with rc=-22 > > > > ... but that seems reasonable given that the DT that of_irq_parse_pci() > > parses is missing, and did correctly trigger the fallback path, so > > everything still worked. > > Yes, this should be normal. It spits this error for old DTs, but keeps > doing the right thing. I'm not sure if we should downgrade this to info > or dbg. No, I think printing an error like this is appropriate: it is an incentive to update the dts files, but doesn't look too urgent as long as everything still works. Arnd