From: Mark Brown <broonie@kernel.org>
To: RongJun Ying <rjying@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>,
DL-SHA-WorkGroupLinux <workgroup.linux@csr.com>,
Rongjun Ying <rongjun.ying@csr.com>
Subject: Re: [PATCH v5-resend 2/7] ASoC: sirf: Add SiRF audio port driver is used by SiRF internal audio codec
Date: Fri, 7 Mar 2014 09:49:57 +0800 [thread overview]
Message-ID: <20140307014957.GR13126@sirena.org.uk> (raw)
In-Reply-To: <CAByv0RN0NBfaMA4TZgeB6f+MmTQ+CE6ztQ_DHXKZdTxQ7tkwQg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 613 bytes --]
On Thu, Mar 06, 2014 at 05:51:43PM +0800, RongJun Ying wrote:
> 2014-03-06 17:20 GMT+08:00 Mark Brown <broonie@kernel.org>:
> > ...use devm_ioremap_resource() instead, please send a followup patch
> > fixing this.
> The i2s, internal audio codec and audio port use same register physics address
> and size. So if one driver use the devm_ioremap_resource instead.
> The other driver will invoke devm_ioremap_resource failed.
That's buggy - there should only be one device for each register range,
you should have a core MFD driver which gets the hardware resource and
shares the regmap with the client drivers.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-03-07 1:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 8:34 [PATCH v5-resend 0/7] ASoC: add CSR SiRFSoC sound drivers RongJun Ying
2014-03-05 8:34 ` [PATCH v5-resend 1/7] ASoC: sirf: Add SiRF internal audio codec driver RongJun Ying
2014-03-05 8:34 ` [PATCH v5-resend 2/7] ASoC: sirf: Add SiRF audio port driver is used by SiRF internal audio codec RongJun Ying
2014-03-06 9:20 ` Mark Brown
2014-03-06 9:51 ` RongJun Ying
2014-03-07 1:49 ` Mark Brown [this message]
2014-03-12 9:56 ` RongJun Ying
2014-03-12 12:00 ` Mark Brown
2014-03-05 8:34 ` [PATCH v5-resend 3/7] ASoC: sirf: Add SiRF audio card RongJun Ying
2014-03-06 9:22 ` Mark Brown
2014-03-05 8:34 ` [PATCH v5-resend 4/7] ASoC: sirf: Add SiRF I2S driver RongJun Ying
2014-03-07 6:05 ` Mark Brown
2014-03-07 7:13 ` RongJun Ying
2014-03-07 8:38 ` RongJun Ying
2014-03-05 8:34 ` [PATCH v5-resend 5/7] ASoC: sirf: Add hdmi card RongJun Ying
2014-03-07 6:06 ` Mark Brown
2014-03-05 8:34 ` [PATCH v5-resend 6/7] ASoC: sirf: Add usp driver which is used by dsp mode RongJun Ying
2014-03-07 6:15 ` Mark Brown
2014-03-05 8:34 ` [PATCH v5-resend 7/7] ASoC: sirf: Add bt-sco card RongJun Ying
2014-03-07 6:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307014957.GR13126@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=rjying@gmail.com \
--cc=rongjun.ying@csr.com \
--cc=tiwai@suse.de \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.